fix(core): Fixes accounts and moves it to codegen (#644)

- [X] Fixes TimeSpan not working with codegen
- [X] Fixes bad check for generic classes with a serialize method and deserialize ctor
- [X] Moves Accounts to codegen so it is versioned
- [X] Fixes deserialization of old Accounts with no version variable.
- [X] Fixes deserialize seek not doing anything. 🙈 
- [X] Adds Email to serialization

Projects/UOContent/Accounting/AccountComment.cs

@@ -64,23 +64,6 @@ namespace Server.Accounting
         /// </summary>
         public DateTime LastModified { get; private set; }
 
-        /// <summary>
-        ///     Serializes this AccountComment instance to an XmlTextWriter.
-        /// </summary>
-        /// <param name="xml">The XmlTextWriter instance from which to serialize.</param>
-        public void Save(XmlTextWriter xml)
-        {
-            xml.WriteStartElement("comment");
-
-            xml.WriteAttributeString("addedBy", AddedBy);
-
-            xml.WriteAttributeString("lastModified", XmlConvert.ToString(LastModified, XmlDateTimeSerializationMode.Utc));
-
-            xml.WriteString(m_Content);
-
-            xml.WriteEndElement();
-        }
-
         /// <summary>
         ///     Serializes this AccountComment instance.
         /// </summary>

Projects/UOContent/Accounting/AccountTag.cs

@@ -45,18 +45,6 @@ namespace Server.Accounting
         /// </summary>
         public string Value { get; set; }
 
-        /// <summary>
-        ///     Serializes this AccountTag instance to an XmlTextWriter.
-        /// </summary>
-        /// <param name="xml">The XmlTextWriter instance from which to serialize.</param>
-        public void Save(XmlTextWriter xml)
-        {
-            xml.WriteStartElement("tag");
-            xml.WriteAttributeString("name", Name);
-            xml.WriteString(Value);
-            xml.WriteEndElement();
-        }
-
         /// <summary>
         ///     Serializes this AccountTag instance to an XmlTextWriter.
         /// </summary>

Projects/UOContent/Accounting/Accounts.cs

@@ -10,8 +10,8 @@ namespace Server.Accounting
     {
         private static readonly ILogger logger = LogFactory.GetLogger(typeof(Accounts));
 
-        private static readonly Dictionary<string, IAccount> _accountsByName = new(32, StringComparer.OrdinalIgnoreCase);
-        private static Dictionary<Serial, IAccount> _accountsById = new(32);
+        private static readonly Dictionary<string, Account> _accountsByName = new(32, StringComparer.OrdinalIgnoreCase);
+        private static Dictionary<Serial, Account> _accountsById = new(32);
         private static Serial _lastAccount;
         internal static List<Type> Types { get; } = new();
 
@@ -44,7 +44,7 @@ namespace Server.Accounting
             Persistence.Register("Accounts", Serialize, WriteSnapshot, Deserialize);
 
         internal static void Serialize() =>
-            EntityPersistence.SaveEntities(_accountsById.Values, account => account.Serialize());
+            EntityPersistence.SaveEntities(_accountsById.Values, account => ((ISerializable)account).Serialize());
 
         internal static void WriteSnapshot(string basePath)
         {
@@ -54,19 +54,19 @@ namespace Server.Accounting
 
         public static IEnumerable<IAccount> GetAccounts() => _accountsByName.Values;
 
-        public static IAccount GetAccount(string username)
+        public static Account GetAccount(string username)
         {
             _accountsByName.TryGetValue(username, out var a);
             return a;
         }
 
-        public static void Add(IAccount a)
+        public static void Add(Account a)
         {
             _accountsByName[a.Username] = a;
             _accountsById[a.Serial] = a;
         }
 
-        public static void Remove(IAccount a)
+        public static void Remove(Account a)
         {
             _accountsByName.Remove(a.Username);
             _accountsById.Remove(a.Serial);
@@ -85,7 +85,7 @@ namespace Server.Accounting
 
             IIndexInfo<Serial> indexInfo = new EntityTypeIndex("Accounts");
 
-            _accountsById = EntityPersistence.LoadIndex(path, indexInfo, out List<EntityIndex<IAccount>> accounts);
+            _accountsById = EntityPersistence.LoadIndex(path, indexInfo, out List<EntityIndex<Account>> accounts);
             EntityPersistence.LoadData(path, indexInfo, accounts);
 
             foreach (var a in _accountsById.Values)