fix(core): Optimizes strings / .NET 5 compatibility changes (#354)

- [X] Removes some string allocations (e.g. split)
- [X] Optimizes some collections
- [X] Converts insensitive to extension methods of built-ins.
- [X] Adds ordinal (case sensitive) string helpers
- [X] Fixes conditionals for in-game commands so they use Ordinal comparisons.
- [X] Replaces ToLower.Contains with InsensitiveContains
- [X] Adds ValueStringBuilder
- [X] Implements ValueStringBuilder in a few places where it makes sense
- [X] Removes the redundant Wrap function and replaces it with an optimized version
- [X] Fixes list conversions in Utility

Closes #351

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-20 23:21:55 -08:00 • committed by GitHub
parent 92aae8d482
commit 77ce2e1980
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
117 changed files with 2000 additions and 1226 deletions

View file

@ -120,7 +120,7 @@ namespace Server.Guilds
for (var i = 0; i < disallowed.Length; i++)
{
if (s.IndexOf(disallowed[i], StringComparison.Ordinal) != -1)
if (s.IndexOfOrdinal(disallowed[i]) != -1)
{
return false;
}

View file

@ -26,7 +26,7 @@ namespace Server.Guilds
"",
0,
GuildDisplayType.All,
World.Guilds.Values.CastListCovariant<BaseGuild, Guild>(),
World.Guilds.Values.SafeConvertList<BaseGuild, Guild>(),
1063136 + (int)GuildDisplayType.All
)
{
@ -44,7 +44,7 @@ namespace Server.Guilds
filter,
startNumber,
display,
World.Guilds.Values.CastListCovariant<BaseGuild, Guild>(),
World.Guilds.Values.SafeConvertList<BaseGuild, Guild>(),
1063136 + (int)display
)
{
@ -224,7 +224,7 @@ namespace Server.Guilds
}
}
return !(Insensitive.Contains(g.Name, filter) || Insensitive.Contains(g.Abbreviation, filter));
return !(g.Name.InsensitiveContains(filter) || g.Abbreviation.InsensitiveContains(filter));
}
public override Gump GetResentGump(
@ -285,7 +285,7 @@ namespace Server.Guilds
return 1;
}
return Insensitive.Compare(x.Name, y.Name);
return x.Name.InsensitiveCompare(y.Name);
}
}
@ -365,7 +365,7 @@ namespace Server.Guilds
return 1;
}
return Insensitive.Compare(x.Abbreviation, y.Abbreviation);
return x.Abbreviation.InsensitiveCompare(y.Abbreviation);
}
}
}

View file

@ -277,7 +277,7 @@ namespace Server.Guilds
}
else
{
if (Insensitive.Equals(title, "none"))
if (title.InsensitiveEquals("none"))
{
m_Member.GuildTitle = null;
}

View file

@ -85,7 +85,7 @@ namespace Server.Guilds
return true;
}
return !Insensitive.Contains(pm.Name, filter);
return !pm.Name.InsensitiveContains(filter);
}
public override Gump GetResentGump(
@ -208,7 +208,7 @@ namespace Server.Guilds
return 1;
}
return Insensitive.Compare(x.Name, y.Name);
return x.Name.InsensitiveCompare(y.Name);
}
}
@ -276,7 +276,7 @@ namespace Server.Guilds
return 1;
}
return Insensitive.Compare(x.GuildTitle, y.GuildTitle);
return x.GuildTitle.InsensitiveCompare(y.GuildTitle);
}
}