fix(core): Optimizes strings / .NET 5 compatibility changes (#354)

- [X] Removes some string allocations (e.g. split)
- [X] Optimizes some collections
- [X] Converts insensitive to extension methods of built-ins.
- [X] Adds ordinal (case sensitive) string helpers
- [X] Fixes conditionals for in-game commands so they use Ordinal comparisons.
- [X] Replaces ToLower.Contains with InsensitiveContains
- [X] Adds ValueStringBuilder
- [X] Implements ValueStringBuilder in a few places where it makes sense
- [X] Removes the redundant Wrap function and replaces it with an optimized version
- [X] Fixes list conversions in Utility

Closes #351

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-20 23:21:55 -08:00 • committed by GitHub
parent 92aae8d482
commit 77ce2e1980
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
117 changed files with 2000 additions and 1226 deletions

View file

@ -81,17 +81,17 @@ namespace Server.Items
if (format != null)
{
if (format.StartsWith("the head of ", StringComparison.Ordinal))
if (format.StartsWithOrdinal("the head of "))
{
format = format.Substring(14); // "the head of|..."
}
if (format.EndsWith(", taken in a duel", StringComparison.Ordinal))
if (format.EndsWithOrdinal(", taken in a duel"))
{
format = format.Substring(0, format.Length - ", taken in a duel".Length);
HeadType = HeadType.Duel;
}
else if (format.EndsWith(", taken in a tournament", StringComparison.Ordinal))
else if (format.EndsWithOrdinal(", taken in a tournament"))
{
format = format.Substring(0, format.Length - ", taken in a tournament".Length);
HeadType = HeadType.Tournament;

View file

@ -2,6 +2,7 @@ using System;
using System.Collections.Generic;
using System.IO;
using System.Text;
using Server.Buffers;
using Server.ContextMenus;
using Server.Gumps;
using Server.Multis;
@ -119,7 +120,7 @@ namespace Server.Items
{
get
{
var sb = new StringBuilder();
using var sb = new ValueStringBuilder(stackalloc char[256]);
foreach (var bpi in Pages)
{

View file

@ -1,6 +1,7 @@
using System;
using System.Collections.Generic;
using System.Text;
using Server.Buffers;
using Server.Mobiles;
using Server.Network;
using Server.Spells;
@ -594,7 +595,7 @@ namespace Server.Items
{
isMatch = true;
}
else if (m_Substring != null && e.Speech.ToLower().Contains(m_Substring.ToLower(), StringComparison.Ordinal))
else if (m_Substring != null && e.Speech.InsensitiveContains(m_Substring))
{
isMatch = true;
}
@ -1189,7 +1190,7 @@ namespace Server.Items
{
base.GetProperties(list);
var props = new StringBuilder();
using var props = new ValueStringBuilder(stackalloc char[128]);
if (GetFlag(ConditionFlag.DenyMounted))
{

View file

@ -262,7 +262,7 @@ namespace Server.Gumps
return 1;
}
var result = Insensitive.Compare(x.From.Name, y.From.Name);
var result = x.From.Name.InsensitiveCompare(y.From.Name);
return result == 0 ? x.Date.CompareTo(y.Date) : result;
}
@ -310,7 +310,7 @@ namespace Server.Gumps
return 1;
}
var result = Insensitive.Compare(a.Username, b.Username);
var result = a.Username.InsensitiveCompare(b.Username);
return result == 0 ? x.Date.CompareTo(y.Date) : result;
}