fix(core): Optimizes strings / .NET 5 compatibility changes (#354)

- [X] Removes some string allocations (e.g. split)
- [X] Optimizes some collections
- [X] Converts insensitive to extension methods of built-ins.
- [X] Adds ordinal (case sensitive) string helpers
- [X] Fixes conditionals for in-game commands so they use Ordinal comparisons.
- [X] Replaces ToLower.Contains with InsensitiveContains
- [X] Adds ValueStringBuilder
- [X] Implements ValueStringBuilder in a few places where it makes sense
- [X] Removes the redundant Wrap function and replaces it with an optimized version
- [X] Fixes list conversions in Utility

Closes #351

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-20 23:21:55 -08:00 • committed by GitHub
parent 92aae8d482
commit 77ce2e1980
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
117 changed files with 2000 additions and 1226 deletions

View file

@ -1,5 +1,6 @@
using System;
using System.Text;
using Server.Buffers;
using Server.Items;
using Server.Mobiles;
using Server.Targeting;
@ -75,12 +76,12 @@ namespace Server.SkillHandlers
if (c.Looters.Count > 0)
{
var sb = new StringBuilder();
using var sb = new ValueStringBuilder(stackalloc char[128]);
for (var i = 0; i < c.Looters.Count; i++)
{
if (i > 0)
{
sb.Append(", ");
sb.Append(i == c.Looters.Count - 1 ? ", and " : ", ");
}
sb.Append(c.Looters[i].Name);
@ -89,7 +90,7 @@ namespace Server.SkillHandlers
from.SendLocalizedMessage(
1042752,
sb.ToString()
); // This body has been distrubed by ~1_PLAYER_NAMES~
); // This body has been disturbed by ~1_PLAYER_NAMES~
}
else
{