fix(core): Optimizes strings / .NET 5 compatibility changes (#354)

- [X] Removes some string allocations (e.g. split)
- [X] Optimizes some collections
- [X] Converts insensitive to extension methods of built-ins.
- [X] Adds ordinal (case sensitive) string helpers
- [X] Fixes conditionals for in-game commands so they use Ordinal comparisons.
- [X] Replaces ToLower.Contains with InsensitiveContains
- [X] Adds ValueStringBuilder
- [X] Implements ValueStringBuilder in a few places where it makes sense
- [X] Removes the redundant Wrap function and replaces it with an optimized version
- [X] Fixes list conversions in Utility

Closes #351

Bumps release version

Projects/UOContent.Tests/Tests/Accounting/Security/PasswordProtectionTest.cs

@@ -0,0 +1,44 @@
+using System;
+using Server.Accounting;
+using Server.Accounting.Security;
+using Xunit;
+
+namespace Server.Tests.Accounting.Security
+{
+    public class PasswordProtectionTest
+    {
+        private const string plainPassword = "hello-good-sir";
+
+        [Theory, InlineData(typeof(Argon2PasswordProtection)), InlineData(typeof(PBKDF2PasswordProtection)),
+         InlineData(typeof(SHA2PasswordProtection)), InlineData(typeof(SHA1PasswordProtection)),
+         InlineData(typeof(MD5PasswordProtection))]
+        public void TestValidates(Type protectionType)
+        {
+            var passwordProtection = Activator.CreateInstance(protectionType) as IPasswordProtection;
+            if (passwordProtection == null)
+            {
+                Assert.False(true, $"{protectionType.Name} is not an IPasswordProtection.");
+            }
+
+            var encryptedPassword = passwordProtection.EncryptPassword(plainPassword);
+
+            Assert.True(passwordProtection.ValidatePassword(encryptedPassword, plainPassword));
+        }
+
+        [Theory, InlineData(typeof(Argon2PasswordProtection)), InlineData(typeof(PBKDF2PasswordProtection)),
+         InlineData(typeof(SHA2PasswordProtection)), InlineData(typeof(SHA1PasswordProtection)),
+         InlineData(typeof(MD5PasswordProtection))]
+        public void TestPasswordDoesNotValidate(Type protectionType)
+        {
+            var passwordProtection = Activator.CreateInstance(protectionType) as IPasswordProtection;
+            if (passwordProtection == null)
+            {
+                Assert.False(true, $"{protectionType.Name} is not an IPasswordProtection.");
+            }
+
+            var encryptedPassword = passwordProtection.EncryptPassword(plainPassword);
+
+            Assert.False(passwordProtection.ValidatePassword(encryptedPassword, "Not the same password"));
+        }
+    }
+}

Projects/UOContent.Tests/Tests/Firewall/FirewallEntryTests.cs

@@ -0,0 +1,20 @@
+using System;
+using System.Net;
+using Xunit;
+
+namespace Server.Tests
+{
+    public class FirewallEntryTests
+    {
+        [Theory]
+        [InlineData("192.168.1.1/24", typeof(Firewall.CIDRFirewallEntry), "192.168.1.50")]
+        [InlineData("192.168.*.100-200", typeof(Firewall.WildcardIPFirewallEntry), "192.168.30.150")]
+        [InlineData("::1234:*:1000-1234", typeof(Firewall.WildcardIPFirewallEntry), "::1234:5678:1150")]
+        public void TestFirewallEntry(string entry, Type entryType, string ipToMatch)
+        {
+            var firewallEntry = Firewall.ToFirewallEntry(entry);
+            Assert.IsType(entryType, firewallEntry);
+            Assert.True(firewallEntry.IsBlocked(IPAddress.Parse(ipToMatch)));
+        }
+    }
+}

Projects/UOContent.Tests/Tests/Network/Packets/ArrowPacketTests.cs

@@ -0,0 +1,63 @@
+using System;
+using Server.Network;
+using Xunit;
+
+namespace Server.Tests.Network
+{
+    public class ArrowPacketTests
+    {
+        [Fact]
+        public void TestCancelArrow()
+        {
+            var expected = new CancelArrow().Compile();
+
+            using var ns = PacketTestUtilities.CreateTestNetState();
+            ns.SendCancelArrow(0, 0, Serial.Zero);
+
+            var result = ns.SendPipe.Reader.TryRead();
+            AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
+        }
+
+        [Theory, InlineData(0, 0), InlineData(100, 10), InlineData(100000, 100000)]
+        public void TestSetArrow(int x, int y)
+        {
+            var expected = new SetArrow(x, y).Compile();
+
+            using var ns = PacketTestUtilities.CreateTestNetState();
+            ns.SendSetArrow(x, y, Serial.Zero);
+
+            var result = ns.SendPipe.Reader.TryRead();
+            AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
+        }
+
+        [Theory, InlineData(0, 0), InlineData(100, 10), InlineData(100000, 100000)]
+        public void TestCancelArrowHS(int x, int y)
+        {
+            Serial serial = 0x1024;
+
+            var expected = new CancelArrowHS(x, y, serial).Compile();
+
+            using var ns = PacketTestUtilities.CreateTestNetState();
+            ns.ProtocolChanges = ProtocolChanges.HighSeas;
+            ns.SendCancelArrow(x, y, serial);
+
+            var result = ns.SendPipe.Reader.TryRead();
+            AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
+        }
+
+        [Theory, InlineData(0, 0), InlineData(100, 10), InlineData(100000, 100000)]
+        public void TestSetArrowHS(int x, int y)
+        {
+            Serial serial = 0x1024;
+
+            var expected = new SetArrowHS(x, y, serial).Compile();
+
+            using var ns = PacketTestUtilities.CreateTestNetState();
+            ns.ProtocolChanges = ProtocolChanges.HighSeas;
+            ns.SendSetArrow(x, y, serial);
+
+            var result = ns.SendPipe.Reader.TryRead();
+            AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
+        }
+    }
+}

Projects/UOContent.Tests/Tests/Network/Packets/ArrowPackets.cs

@@ -0,0 +1,59 @@
+/*************************************************************************
+ * ModernUO                                                              *
+ * Copyright 2019-2020 - ModernUO Development Team                       *
+ * Email: hi@modernuo.com                                                *
+ * File: ArrowPackets.cs                                                 *
+ *                                                                       *
+ * This program is free software: you can redistribute it and/or modify  *
+ * it under the terms of the GNU General Public License as published by  *
+ * the Free Software Foundation, either version 3 of the License, or     *
+ * (at your option) any later version.                                   *
+ *                                                                       *
+ * You should have received a copy of the GNU General Public License     *
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>. *
+ *************************************************************************/
+
+namespace Server.Network
+{
+    public sealed class CancelArrow : Packet
+    {
+        public CancelArrow() : base(0xBA, 6)
+        {
+            Stream.Write((byte)0);
+            Stream.Write((short)-1);
+            Stream.Write((short)-1);
+        }
+    }
+
+    public sealed class SetArrow : Packet
+    {
+        public SetArrow(int x, int y) : base(0xBA, 6)
+        {
+            Stream.Write((byte)1);
+            Stream.Write((short)x);
+            Stream.Write((short)y);
+        }
+    }
+
+    public sealed class CancelArrowHS : Packet
+    {
+        public CancelArrowHS(int x, int y, Serial s) : base(0xBA, 10)
+        {
+            Stream.Write((byte)0);
+            Stream.Write((short)x);
+            Stream.Write((short)y);
+            Stream.Write(s);
+        }
+    }
+
+    public sealed class SetArrowHS : Packet
+    {
+        public SetArrowHS(int x, int y, Serial s) : base(0xBA, 10)
+        {
+            Stream.Write((byte)1);
+            Stream.Write((short)x);
+            Stream.Write((short)y);
+            Stream.Write(s);
+        }
+    }
+}