From 24430839adc61bea140647cc151e6da9b9feb04e Mon Sep 17 00:00:00 2001
From: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
Date: Sat, 5 Oct 2019 11:03:36 -0700
Subject: [PATCH 1/3] Hotfixes issues with Insensitive and WorkQueue

---
 Projects/Server/Insensitive.cs         | 43 ++++++--------------------
 Projects/Server/Main.cs                |  4 +--
 Projects/Server/Network/MessagePump.cs |  4 +--
 3 files changed, 13 insertions(+), 38 deletions(-)

diff --git a/Projects/Server/Insensitive.cs b/Projects/Server/Insensitive.cs
index c46c0a6e4..8156b85a1 100644
--- a/Projects/Server/Insensitive.cs
+++ b/Projects/Server/Insensitive.cs
@@ -25,45 +25,20 @@ namespace Server
 {
   public static class Insensitive
   {
-    public static IComparer<string> Comparer{ get; } = StringComparer.OrdinalIgnoreCase;
+    public static IComparer<string> Comparer { get; } = StringComparer.OrdinalIgnoreCase;
 
     public static int Compare(string a, string b) => Comparer.Compare(a, b);
 
-    public static bool Equals(string a, string b)
-    {
-      if (a == null && b == null)
-        return true;
-      if (a == null || b == null || a.Length != b.Length)
-        return false;
+    public static bool Equals(string a, string b) =>
+      a == null && b == null || a != null && b != null && a.Length == b.Length && Comparer.Compare(a, b) == 0;
 
-      return Comparer.Compare(a, b) == 0;
-    }
+    public static bool StartsWith(string a, string b) =>
+      a != null && b != null && a.Length >= b.Length && Comparer.Compare(a.Substring(0, b.Length), b) == 0;
 
-    public static bool StartsWith(string a, string b)
-    {
-      if (a == null || b == null || a.Length < b.Length)
-        return false;
+    public static bool EndsWith(string a, string b) =>
+      a != null && b != null && a.Length >= b.Length && Comparer.Compare(a.Substring(a.Length - b.Length), b) == 0;
 
-      return Comparer.Compare(a.Substring(0, b.Length), b) == 0;
-    }
-
-    public static bool EndsWith(string a, string b)
-    {
-      if (a == null || b == null || a.Length < b.Length)
-        return false;
-
-      return Comparer.Compare(a.Substring(a.Length - b.Length), b) == 0;
-    }
-
-    public static bool Contains(string a, string b)
-    {
-      if (a == null || b == null || a.Length < b.Length)
-        return false;
-
-      a = a.ToLower();
-      b = b.ToLower();
-
-      return a.IndexOf(b) >= 0;
-    }
+    public static bool Contains(string a, string b) =>
+      a != null && b != null && a.Length >= b.Length && a.IndexOf(b, StringComparison.OrdinalIgnoreCase) >= 0;
   }
 }
diff --git a/Projects/Server/Main.cs b/Projects/Server/Main.cs
index db8a9a209..53a975885 100644
--- a/Projects/Server/Main.cs
+++ b/Projects/Server/Main.cs
@@ -474,8 +474,8 @@ namespace Server
           m_Signal.WaitOne();
 
           Task.WaitAll(
-            Task.Run(() => Mobile.ProcessDeltaQueue()),
-            Task.Run(() => Item.ProcessDeltaQueue())
+            Task.Run(Mobile.ProcessDeltaQueue),
+            Task.Run(Item.ProcessDeltaQueue)
           );
 
           Timer.Slice();
diff --git a/Projects/Server/Network/MessagePump.cs b/Projects/Server/Network/MessagePump.cs
index 30243de09..0919630d9 100644
--- a/Projects/Server/Network/MessagePump.cs
+++ b/Projects/Server/Network/MessagePump.cs
@@ -48,8 +48,8 @@ namespace Server.Network
 
     public void DoWork()
     {
-      int count = m_WorkQueue.Count;
-      while (count-- > 0)
+      int count = 0;
+      while (!m_WorkQueue.IsEmpty && count++ < 250)
       {
         if (!m_WorkQueue.TryDequeue(out Work work))
           break;

From 39439c68b8a9133817fa156e27ddc8c45415695e Mon Sep 17 00:00:00 2001
From: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
Date: Sat, 5 Oct 2019 11:28:40 -0700
Subject: [PATCH 2/3] Make debug builds easier

---
 Projects/Scripts/Scripts.csproj                               | 4 ++++
 .../Properties/PublishProfiles/Linux-SelfContained.pubxml     | 2 +-
 Projects/Server/Properties/PublishProfiles/Linux.pubxml       | 2 +-
 .../Properties/PublishProfiles/OSX-SelfContained.pubxml       | 2 +-
 Projects/Server/Properties/PublishProfiles/OSX.pubxml         | 2 +-
 .../Properties/PublishProfiles/Windows-SelfContained.pubxml   | 2 +-
 Projects/Server/Properties/PublishProfiles/Windows.pubxml     | 2 +-
 7 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/Projects/Scripts/Scripts.csproj b/Projects/Scripts/Scripts.csproj
index ec0097b1c..be8669f4d 100644
--- a/Projects/Scripts/Scripts.csproj
+++ b/Projects/Scripts/Scripts.csproj
@@ -11,12 +11,16 @@
     <WarningsAsErrors />
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <PlatformTarget>x64</PlatformTarget>
+    <OutDir>..\..\Distribution\Assemblies</OutDir>
+    <OutputPath>..\..\Distribution\Assemblies</OutputPath>
     <PublishDir>..\..\Distribution\Assemblies</PublishDir>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
     <DefineConstants>TRACE;DEBUG</DefineConstants>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <Optimize>false</Optimize>
+    <OutDir>..\..\Distribution\Assemblies</OutDir>
+    <OutputPath>..\..\Distribution\Assemblies</OutputPath>
     <PublishDir>..\..\Distribution\Assemblies</PublishDir>
     <WarningsAsErrors />
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
diff --git a/Projects/Server/Properties/PublishProfiles/Linux-SelfContained.pubxml b/Projects/Server/Properties/PublishProfiles/Linux-SelfContained.pubxml
index c43c47567..d9042b76c 100644
--- a/Projects/Server/Properties/PublishProfiles/Linux-SelfContained.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/Linux-SelfContained.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <Configuration>Release</Configuration>
+    <!-- <Configuration>Release</Configuration> -->
     <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
     <SelfContained>true</SelfContained>
     <PublishTrimmed>true</PublishTrimmed>
diff --git a/Projects/Server/Properties/PublishProfiles/Linux.pubxml b/Projects/Server/Properties/PublishProfiles/Linux.pubxml
index fb76af4c2..e1a61d7a4 100644
--- a/Projects/Server/Properties/PublishProfiles/Linux.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/Linux.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <Configuration>Release</Configuration>
+    <!-- <Configuration>Release</Configuration> -->
     <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
     <SelfContained>false</SelfContained>
   </PropertyGroup>
diff --git a/Projects/Server/Properties/PublishProfiles/OSX-SelfContained.pubxml b/Projects/Server/Properties/PublishProfiles/OSX-SelfContained.pubxml
index 2f9813651..370cda77d 100644
--- a/Projects/Server/Properties/PublishProfiles/OSX-SelfContained.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/OSX-SelfContained.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <Configuration>Release</Configuration>
+    <!-- <Configuration>Release</Configuration> -->
     <RuntimeIdentifier>osx-x64</RuntimeIdentifier>
     <SelfContained>true</SelfContained>
     <PublishTrimmed>true</PublishTrimmed>
diff --git a/Projects/Server/Properties/PublishProfiles/OSX.pubxml b/Projects/Server/Properties/PublishProfiles/OSX.pubxml
index 7c45904d8..d0705df7c 100644
--- a/Projects/Server/Properties/PublishProfiles/OSX.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/OSX.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <Configuration>Release</Configuration>
+    <!-- <Configuration>Release</Configuration> -->
     <RuntimeIdentifier>osx-x64</RuntimeIdentifier>
     <SelfContained>false</SelfContained>
   </PropertyGroup>
diff --git a/Projects/Server/Properties/PublishProfiles/Windows-SelfContained.pubxml b/Projects/Server/Properties/PublishProfiles/Windows-SelfContained.pubxml
index a43797ef8..f778e026a 100644
--- a/Projects/Server/Properties/PublishProfiles/Windows-SelfContained.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/Windows-SelfContained.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <Configuration>Release</Configuration>
+    <!-- <Configuration>Release</Configuration> -->
     <RuntimeIdentifier>win-x64</RuntimeIdentifier>
     <SelfContained>true</SelfContained>
     <PublishTrimmed>true</PublishTrimmed>
diff --git a/Projects/Server/Properties/PublishProfiles/Windows.pubxml b/Projects/Server/Properties/PublishProfiles/Windows.pubxml
index c6a68c538..02f5e9052 100644
--- a/Projects/Server/Properties/PublishProfiles/Windows.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/Windows.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <Configuration>Release</Configuration>
+    <!-- <Configuration>Release</Configuration> -->
     <RuntimeIdentifier>win-x64</RuntimeIdentifier>
     <SelfContained>false</SelfContained>
   </PropertyGroup>

From cc5a59309c7131a724f7183b28fdbd27280c65b1 Mon Sep 17 00:00:00 2001
From: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
Date: Sat, 5 Oct 2019 11:51:15 -0700
Subject: [PATCH 3/3] Fixes builds in windows.

---
 Projects/Scripts/Scripts.csproj                            | 1 +
 .../Properties/PublishProfiles/Linux-SelfContained.pubxml  | 2 +-
 Projects/Server/Properties/PublishProfiles/Linux.pubxml    | 2 +-
 .../Properties/PublishProfiles/OSX-SelfContained.pubxml    | 2 +-
 Projects/Server/Properties/PublishProfiles/OSX.pubxml      | 2 +-
 .../PublishProfiles/Windows-SelfContained.pubxml           | 2 +-
 Projects/Server/Properties/PublishProfiles/Windows.pubxml  | 2 +-
 Projects/Server/Server.csproj                              | 7 ++++---
 8 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/Projects/Scripts/Scripts.csproj b/Projects/Scripts/Scripts.csproj
index be8669f4d..f3b49987e 100644
--- a/Projects/Scripts/Scripts.csproj
+++ b/Projects/Scripts/Scripts.csproj
@@ -4,6 +4,7 @@
     <RootNamespace>Server</RootNamespace>
     <TargetFramework>netcoreapp3.0</TargetFramework>
     <AssemblyName>Scripts.CS</AssemblyName>
+    <UseNETCoreGenerator>true</UseNETCoreGenerator>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
diff --git a/Projects/Server/Properties/PublishProfiles/Linux-SelfContained.pubxml b/Projects/Server/Properties/PublishProfiles/Linux-SelfContained.pubxml
index d9042b76c..c43c47567 100644
--- a/Projects/Server/Properties/PublishProfiles/Linux-SelfContained.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/Linux-SelfContained.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <!-- <Configuration>Release</Configuration> -->
+    <Configuration>Release</Configuration>
     <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
     <SelfContained>true</SelfContained>
     <PublishTrimmed>true</PublishTrimmed>
diff --git a/Projects/Server/Properties/PublishProfiles/Linux.pubxml b/Projects/Server/Properties/PublishProfiles/Linux.pubxml
index e1a61d7a4..fb76af4c2 100644
--- a/Projects/Server/Properties/PublishProfiles/Linux.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/Linux.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <!-- <Configuration>Release</Configuration> -->
+    <Configuration>Release</Configuration>
     <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
     <SelfContained>false</SelfContained>
   </PropertyGroup>
diff --git a/Projects/Server/Properties/PublishProfiles/OSX-SelfContained.pubxml b/Projects/Server/Properties/PublishProfiles/OSX-SelfContained.pubxml
index 370cda77d..2f9813651 100644
--- a/Projects/Server/Properties/PublishProfiles/OSX-SelfContained.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/OSX-SelfContained.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <!-- <Configuration>Release</Configuration> -->
+    <Configuration>Release</Configuration>
     <RuntimeIdentifier>osx-x64</RuntimeIdentifier>
     <SelfContained>true</SelfContained>
     <PublishTrimmed>true</PublishTrimmed>
diff --git a/Projects/Server/Properties/PublishProfiles/OSX.pubxml b/Projects/Server/Properties/PublishProfiles/OSX.pubxml
index d0705df7c..7c45904d8 100644
--- a/Projects/Server/Properties/PublishProfiles/OSX.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/OSX.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <!-- <Configuration>Release</Configuration> -->
+    <Configuration>Release</Configuration>
     <RuntimeIdentifier>osx-x64</RuntimeIdentifier>
     <SelfContained>false</SelfContained>
   </PropertyGroup>
diff --git a/Projects/Server/Properties/PublishProfiles/Windows-SelfContained.pubxml b/Projects/Server/Properties/PublishProfiles/Windows-SelfContained.pubxml
index f778e026a..a43797ef8 100644
--- a/Projects/Server/Properties/PublishProfiles/Windows-SelfContained.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/Windows-SelfContained.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <!-- <Configuration>Release</Configuration> -->
+    <Configuration>Release</Configuration>
     <RuntimeIdentifier>win-x64</RuntimeIdentifier>
     <SelfContained>true</SelfContained>
     <PublishTrimmed>true</PublishTrimmed>
diff --git a/Projects/Server/Properties/PublishProfiles/Windows.pubxml b/Projects/Server/Properties/PublishProfiles/Windows.pubxml
index 02f5e9052..c6a68c538 100644
--- a/Projects/Server/Properties/PublishProfiles/Windows.pubxml
+++ b/Projects/Server/Properties/PublishProfiles/Windows.pubxml
@@ -2,7 +2,7 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <!-- <Configuration>Release</Configuration> -->
+    <Configuration>Release</Configuration>
     <RuntimeIdentifier>win-x64</RuntimeIdentifier>
     <SelfContained>false</SelfContained>
   </PropertyGroup>
diff --git a/Projects/Server/Server.csproj b/Projects/Server/Server.csproj
index c564d5e6b..e7ce12400 100644
--- a/Projects/Server/Server.csproj
+++ b/Projects/Server/Server.csproj
@@ -14,6 +14,7 @@
     <Copyright>2019</Copyright>
     <TargetFramework>netcoreapp3.0</TargetFramework>
     <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
+    <UseNETCoreGenerator>true</UseNETCoreGenerator>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
     <DefineConstants>TRACE;DEBUG</DefineConstants>
@@ -38,15 +39,15 @@
     <LangVersion>8.0</LangVersion>
   </PropertyGroup>
   <ItemGroup>
-    <Content Include="Assemblies\zlib.dll" Condition="'$(RuntimeIdentifier)'=='win-x64'">
+    <Content Include="Assemblies\zlib.dll" Condition="'$(RuntimeIdentifier)'=='win-x64' OR !Exists('$(RuntimeIdentifier)')">
       <Link>zlib.dll</Link>
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>
-    <Content Include="Assemblies\rdrand.dll" Condition="'$(RuntimeIdentifier)'=='win-x64'">
+    <Content Include="Assemblies\rdrand.dll" Condition="'$(RuntimeIdentifier)'=='win-x64' OR !Exists('$(RuntimeIdentifier)')">
       <Link>rdrand.dll</Link>
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>
-    <Content Include="Assemblies\rdrand.so" Condition="'$(RuntimeIdentifier)'=='osx-x64' OR '$(RuntimeIdentifier)'=='linux-x64'">
+    <Content Include="Assemblies\rdrand.so" Condition="'$(RuntimeIdentifier)'=='osx-x64' OR '$(RuntimeIdentifier)'=='linux-x64' OR !Exists('$(RuntimeIdentifier)')">
       <Link>rdrand.so</Link>
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>