From 7d748491d0431c896c67c52aa47e37d2e7bb7cb9 Mon Sep 17 00:00:00 2001
From: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
Date: Tue, 24 Jun 2025 10:37:59 -0700
Subject: [PATCH] fix: Fixes empty/missing bank box prevent withdraw from
 account gold (#2219)

---
 Projects/UOContent/Mobiles/Townfolk/Banker.cs | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/Projects/UOContent/Mobiles/Townfolk/Banker.cs b/Projects/UOContent/Mobiles/Townfolk/Banker.cs
index d79cc7055..7bb0c5bd6 100644
--- a/Projects/UOContent/Mobiles/Townfolk/Banker.cs
+++ b/Projects/UOContent/Mobiles/Townfolk/Banker.cs
@@ -12,7 +12,7 @@ namespace Server.Mobiles;
 [SerializationGenerator(0, false)]
 public partial class Banker : BaseVendor
 {
-    private readonly List<SBInfo> m_SBInfos = new();
+    private readonly List<SBInfo> m_SBInfos = [];
 
     [Constructible]
     public Banker() : base("the banker")
@@ -41,7 +41,7 @@ public partial class Banker : BaseVendor
             }
         }
 
-        Container bank = m.FindBankNoCreate();
+        var bank = m.FindBankNoCreate();
 
         if (bank != null)
         {
@@ -80,11 +80,11 @@ public partial class Banker : BaseVendor
             }
         }
 
-        Container bank = m.FindBankNoCreate();
+        var bank = m.FindBankNoCreate();
 
         if (bank != null)
         {
-            gold = new List<Gold>();
+            gold = [];
 
             foreach (var g in bank.FindItemsByType<Gold>())
             {
@@ -97,7 +97,7 @@ public partial class Banker : BaseVendor
                 return int.MaxValue;
             }
 
-            checks = new List<BankCheck>();
+            checks = [];
 
             foreach (var bc in bank.FindItemsByType<BankCheck>())
             {
@@ -111,7 +111,7 @@ public partial class Banker : BaseVendor
 
     private static bool HasRequiredBalance(int requiredBalance, Mobile m, out PooledRefList<Gold> gold, out PooledRefList<BankCheck> checks)
     {
-        Container bank = m.FindBankNoCreate();
+        var bank = m.FindBankNoCreate();
 
         if (bank == null)
         {
@@ -380,11 +380,9 @@ public partial class Banker : BaseVendor
                                 {
                                     Say(1048147); // Your backpack can't hold anything else.
                                 }
-                                else if (amount > 0)
+                                else if (amount <= 0)
                                 {
-                                    var box = e.Mobile.FindBankNoCreate();
-
-                                    if (box == null || !Withdraw(e.Mobile, amount))
+                                    if (!Withdraw(e.Mobile, amount))
                                     {
                                         Say(500384); // Ah, art thou trying to fool me? Thou hast not so much gold!
                                     }