warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes thread guard and cleans up incoming packet reader (#1641)

Browse source 
### Summary
* Fixes syntax compile error when THREADGUARD is enabled.
* Removes `int packetLength` from incoming packet handles since they aren't needed.

### Developer Notes
Incoming packet handler `SpanReader` is now properly scoped to that packet by length.
This commit is contained in:
Kamron Batman 2023-12-19 17:04:09 -08:00 • committed by GitHub
parent 25a75fdf24
commit 7d9bc9ff0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
31 changed files with 190 additions and 157 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Projects/UOContent/Engines/Chat/ChatPackets.cs
View file

@ -27,7 +27,7 @@ namespace Server.Engines.Chat
IncomingPackets.Register(0xB3, 0, true, &ChatAction);
}
public static void OpenChatWindowRequest(NetState state, SpanReader reader, int packetLength)
public static void OpenChatWindowRequest(NetState state, SpanReader reader)
{
var from = state.Mobile;
@ -48,7 +48,7 @@ namespace Server.Engines.Chat
ChatUser.AddChatUser(from, chatName);
}
public static void ChatAction(NetState state, SpanReader reader, int packetLength)
public static void ChatAction(NetState state, SpanReader reader)
{
if (!ChatSystem.Enabled)
{

2
Projects/UOContent/Engines/ML Quests/Gumps/RaceChangeGump.cs
View file

@ -196,7 +196,7 @@ namespace Server.Engines.MLQuests.Gumps
return false;
}
private static void RaceChangeReply(NetState state, SpanReader reader, int packetLength)
private static void RaceChangeReply(NetState state, SpanReader reader)
{
if (!m_Pending.TryGetValue(state, out var raceChangeState))
{

2
Projects/UOContent/Engines/UltimaStore/UltimaStorePackets.cs
View file

@ -10,7 +10,7 @@ namespace Server.Engines.UltimaStore
IncomingPackets.Register(0xFA, 1, true, &UltimaStoreOpenRequest);
}
public static void UltimaStoreOpenRequest(NetState state, SpanReader reader, int packetLength)
public static void UltimaStoreOpenRequest(NetState state, SpanReader reader)
{
state.Mobile.SendMessage("Ultima Store is not currently available.");
}