warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Fixes thread guard and cleans up incoming packet reader (#1641)

Browse source 
### Summary
* Fixes syntax compile error when THREADGUARD is enabled.
* Removes `int packetLength` from incoming packet handles since they aren't needed.

### Developer Notes
Incoming packet handler `SpanReader` is now properly scoped to that packet by length.
This commit is contained in:
Kamron Batman 2023-12-19 17:04:09 -08:00 • committed by GitHub
parent 25a75fdf24
commit 7d9bc9ff0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
31 changed files with 190 additions and 157 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Projects/UOContent/Network/Packets/IncomingMobilePackets.cs
View file

@ -28,7 +28,7 @@ public static class IncomingMobilePackets
IncomingPackets.Register(0x6F, 0, true, &SecureTrade);
}
public static void RenameRequest(NetState state, SpanReader reader, int packetLength)
public static void RenameRequest(NetState state, SpanReader reader)
{
var from = state.Mobile;
var targ = World.FindMobile((Serial)reader.ReadUInt32());
@ -39,7 +39,7 @@ public static class IncomingMobilePackets
}
}
public static void MobileNameRequest(NetState state, SpanReader reader, int packetLength)
public static void MobileNameRequest(NetState state, SpanReader reader)
{
var m = World.FindMobile((Serial)reader.ReadUInt32());
@ -49,7 +49,7 @@ public static class IncomingMobilePackets
}
}
public static void ProfileReq(NetState state, SpanReader reader, int packetLength)
public static void ProfileReq(NetState state, SpanReader reader)
{
int type = reader.ReadByte();
var serial = (Serial)reader.ReadUInt32();
@ -89,7 +89,7 @@ public static class IncomingMobilePackets
}
}
public static void SecureTrade(NetState state, SpanReader reader, int packetLength)
public static void SecureTrade(NetState state, SpanReader reader)
{
switch (reader.ReadByte())
{