fix: Removes wrong error message from Fireflies (#1884)

This commit is contained in:
Kamron Batman 2024-07-23 20:31:02 -07:00 • committed by GitHub
parent 2ff51dbeb6
commit 7dfb45d4eb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 225 additions and 247 deletions

View file

@ -36,36 +36,36 @@ namespace Server.Gumps
return; return;
} }
if (info.ButtonID == (int)Buttons.Confirm) if (info.ButtonID != (int)Buttons.Confirm)
{ {
var m = sender.Mobile; return;
var house = BaseHouse.FindHouseAt(m); }
if (house?.IsOwner(m) == true) var m = sender.Mobile;
{ var house = BaseHouse.FindHouseAt(m);
if (m.InRange(item.Location, 2))
{
var deed = m_Addon.Deed;
if (deed != null) if (house?.IsOwner(m) != true)
{ {
m.AddToBackpack(deed); // You can only re-deed this decoration if you are the house owner or originally placed the decoration.
house.Addons.Remove(item); m.SendLocalizedMessage(1049784);
item.Delete(); return;
} }
}
else if (m.InRange(item.Location, 2))
{ {
m.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that. var deed = m_Addon.Deed;
}
} if (deed != null)
else
{ {
m.SendLocalizedMessage( m.AddToBackpack(deed);
1049784 house.Addons.Remove(item);
); // You can only re-deed this decoration if you are the house owner or originally placed the decoration. item.Delete();
} }
} }
else
{
m.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
}
} }
private enum Buttons private enum Buttons

View file

@ -4,244 +4,222 @@ using Server.Multis;
using Server.Network; using Server.Network;
using Server.Targeting; using Server.Targeting;
namespace Server.Items namespace Server.Items;
[SerializationGenerator(0)]
public partial class Fireflies : Item, IAddon
{ {
[SerializationGenerator(0)] [Constructible]
public partial class Fireflies : Item, IAddon public Fireflies(int itemID = 0x1596) : base(itemID)
{ {
[Constructible] LootType = LootType.Blessed;
public Fireflies(int itemID = 0x1596) Movable = false;
: base(itemID)
{
LootType = LootType.Blessed;
Movable = false;
}
public override int LabelNumber => 1150061;
public bool FacingSouth => ItemID == 0x2336;
public Item Deed => new FirefliesDeed();
public bool CouldFit(IPoint3D p, Map map)
{
if (map?.CanFit(p.X, p.Y, p.Z, ItemData.Height) != true)
{
return false;
}
return FacingSouth ?
BaseAddon.IsWall(p.X, p.Y - 1, p.Z, map) :
BaseAddon.IsWall(p.X - 1, p.Y, p.Z, map);
}
public override void OnDoubleClick(Mobile from)
{
if (from.InRange(Location, 3))
{
var house = BaseHouse.FindHouseAt(this);
if (house?.IsOwner(from) == true)
{
from.CloseGump<RewardDemolitionGump>();
from.SendGump(new RewardDemolitionGump(this, 1049783)); // Do you wish to re-deed this decoration?
}
else
{
from.SendLocalizedMessage(
1049784
); // You can only re-deed this decoration if you are the house owner or originally placed the decoration.
}
}
else
{
from.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
}
}
} }
[SerializationGenerator(0)] public override int LabelNumber => 1150061;
public partial class FirefliesDeed : Item
public bool FacingSouth => ItemID == 0x2336;
public Item Deed => new FirefliesDeed();
public bool CouldFit(IPoint3D p, Map map)
{ {
[Constructible] if (map?.CanFit(p.X, p.Y, p.Z, ItemData.Height) != true)
public FirefliesDeed()
: base(0x14F0)
{ {
LootType = LootType.Blessed; return false;
Weight = 1.0;
} }
public override int LabelNumber => 1150061; return FacingSouth
? BaseAddon.IsWall(p.X, p.Y - 1, p.Z, map)
: BaseAddon.IsWall(p.X - 1, p.Y, p.Z, map);
}
public override void OnDoubleClick(Mobile from) public override void OnDoubleClick(Mobile from)
{
if (!from.InRange(Location, 3))
{ {
if (IsChildOf(from.Backpack)) from.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
{ return;
var house = BaseHouse.FindHouseAt(from);
if (house?.IsOwner(from) == true)
{
from.CloseGump<FacingGump>();
if (!from.SendGump(new FacingGump(this, from)))
{
from.SendLocalizedMessage(1150062); // You fail to re-deed the holiday fireflies.
}
}
else
{
from.SendLocalizedMessage(502092); // You must be in your house to do this.
}
}
else
{
from.SendLocalizedMessage(1042038); // You must have the object in your backpack to use it.
}
} }
private class FacingGump : Gump var house = BaseHouse.FindHouseAt(this);
if (house?.IsOwner(from) == true)
{ {
private readonly FirefliesDeed m_Deed; from.CloseGump<RewardDemolitionGump>();
private readonly Mobile m_Placer; // Do you wish to re-deed this decoration?
from.SendGump(new RewardDemolitionGump(this, 1049783));
public FacingGump(FirefliesDeed deed, Mobile player)
: base(150, 50)
{
m_Deed = deed;
m_Placer = player;
Closable = true;
Disposable = true;
Draggable = true;
Resizable = false;
AddPage(0);
AddBackground(0, 0, 300, 150, 0xA28);
AddItem(90, 30, 0x2332);
AddItem(180, 30, 0x2336);
AddButton(50, 35, 0x868, 0x869, (int)Buttons.East);
AddButton(145, 35, 0x868, 0x869, (int)Buttons.South);
}
public override void OnResponse(NetState sender, in RelayInfo info)
{
int m_ItemID;
switch (info.ButtonID)
{
case (int)Buttons.East:
m_ItemID = 0x2332;
break;
case (int)Buttons.South:
m_ItemID = 0x2336;
break;
default: return;
}
m_Placer.Target = new InternalTarget(m_Deed, m_ItemID);
}
private enum Buttons
{
Cancel,
South,
East
}
} }
else
private class InternalTarget : Target
{ {
private readonly FirefliesDeed m_FirefliesDeed; // You can only re-deed this decoration if you are the house owner or originally placed the decoration.
private readonly int m_ItemID; from.SendLocalizedMessage(1049784);
}
public InternalTarget(FirefliesDeed m_Deed, int itemid) }
: base(-1, true, TargetFlags.None) }
{
m_FirefliesDeed = m_Deed; [SerializationGenerator(0)]
m_ItemID = itemid; public partial class FirefliesDeed : Item
} {
[Constructible]
protected override void OnTarget(Mobile from, object targeted) public FirefliesDeed() : base(0x14F0)
{ {
if (m_FirefliesDeed?.Deleted != false) LootType = LootType.Blessed;
{ Weight = 1.0;
return; }
}
public override int LabelNumber => 1150061;
if (m_FirefliesDeed.IsChildOf(from.Backpack))
{ public override void OnDoubleClick(Mobile from)
var house = BaseHouse.FindHouseAt(from); {
if (!IsChildOf(from.Backpack))
if (house?.IsOwner(from) == true) {
{ from.SendLocalizedMessage(1042038); // You must have the object in your backpack to use it.
var p = targeted as IPoint3D; return;
var map = from.Map; }
if (p == null || map == null || map == Map.Internal) var house = BaseHouse.FindHouseAt(from);
{
return; if (house?.IsOwner(from) != true)
} {
from.SendLocalizedMessage(502092); // You must be in your house to do this.
var p3d = new Point3D(p); return;
var id = TileData.ItemTable[m_ItemID & TileData.MaxItemValue]; }
if (map.CanFit(p3d, id.Height)) from.CloseGump<FacingGump>();
{ from.SendGump(new FacingGump(this, from));
house = BaseHouse.FindHouseAt(p3d, map, id.Height); }
if (house?.IsOwner(from) == true) private class FacingGump : Gump
{ {
var north = BaseAddon.IsWall(p3d.X, p3d.Y - 1, p3d.Z, map); private readonly FirefliesDeed _deed;
var west = BaseAddon.IsWall(p3d.X - 1, p3d.Y, p3d.Z, map); private readonly Mobile _placer;
bool isclear = true; public FacingGump(FirefliesDeed deed, Mobile player) : base(150, 50)
{
foreach (Fireflies fireflies in Map.Malas.GetItemsAt<Fireflies>(p3d)) _deed = deed;
{ _placer = player;
if (fireflies.Z == p3d.Z)
{ Closable = true;
isclear = false; Disposable = true;
} Draggable = true;
} Resizable = false;
if ((m_ItemID == 0x2336 && north || m_ItemID == 0x2332 && west) && isclear) AddPage(0);
{
var flies = new Fireflies(m_ItemID); AddBackground(0, 0, 300, 150, 0xA28);
house.Addons.Add(flies); AddItem(90, 30, 0x2332);
AddItem(180, 30, 0x2336);
flies.MoveToWorld(p3d, from.Map);
AddButton(50, 35, 0x868, 0x869, (int)Buttons.East);
m_FirefliesDeed.Delete(); AddButton(145, 35, 0x868, 0x869, (int)Buttons.South);
} }
else
{ public override void OnResponse(NetState sender, in RelayInfo info)
from.SendLocalizedMessage(1150065); // Holiday fireflies must be placed next to a wall. {
} if (info.ButtonID == (int)Buttons.Cancel)
} {
else return;
{ }
from.SendLocalizedMessage(1042036); // That location is not in your house.
} int itemId = info.ButtonID switch
} {
else (int)Buttons.East => 0x2332,
{ (int)Buttons.South => 0x2336,
from.SendLocalizedMessage(500269); // You cannot build that there. _ => 0
} };
}
else _placer.Target = new InternalTarget(_deed, itemId);
{ }
from.SendLocalizedMessage(502092); // You must be in your house to do this.
} private enum Buttons
} {
else Cancel,
{ South,
from.SendLocalizedMessage(1042038); // You must have the object in your backpack to use it. East
} }
} }
private class InternalTarget : Target
{
private readonly FirefliesDeed _firefliesDeed;
private readonly int _itemId;
public InternalTarget(FirefliesDeed _deed, int itemId) : base(-1, true, TargetFlags.None)
{
_firefliesDeed = _deed;
_itemId = itemId;
}
protected override void OnTarget(Mobile from, object targeted)
{
if (_firefliesDeed?.Deleted != false)
{
return;
}
if (!_firefliesDeed.IsChildOf(from.Backpack))
{
from.SendLocalizedMessage(1042038); // You must have the object in your backpack to use it.
return;
}
var house = BaseHouse.FindHouseAt(from);
if (house?.IsOwner(from) != true)
{
from.SendLocalizedMessage(502092); // You must be in your house to do this.
return;
}
var p = targeted as IPoint3D;
var map = from.Map;
if (p == null || map == null || map == Map.Internal)
{
return;
}
var p3d = new Point3D(p);
var id = TileData.ItemTable[_itemId & TileData.MaxItemValue];
if (!map.CanFit(p3d, id.Height))
{
from.SendLocalizedMessage(500269); // You cannot build that there.
return;
}
house = BaseHouse.FindHouseAt(p3d, map, id.Height);
if (house?.IsOwner(from) != true)
{
from.SendLocalizedMessage(1042036); // That location is not in your house.
return;
}
var north = BaseAddon.IsWall(p3d.X, p3d.Y - 1, p3d.Z, map);
var west = BaseAddon.IsWall(p3d.X - 1, p3d.Y, p3d.Z, map);
if ((_itemId != 0x2336 || !north) && (_itemId != 0x2332 || !west))
{
from.SendLocalizedMessage(1150065); // Holiday fireflies must be placed next to a wall.
return;
}
foreach (Fireflies fireflies in Map.Malas.GetItemsAt<Fireflies>(p3d))
{
if (fireflies.Z == p3d.Z)
{
from.SendLocalizedMessage(1150065); // Holiday fireflies must be placed next to a wall.
return;
}
}
var flies = new Fireflies(_itemId);
house.Addons.Add(flies);
flies.MoveToWorld(p3d, from.Map);
_firefliesDeed.Delete();
} }
} }
} }