fix: Fixes dirty-tracking gaps in generated content: setters, sub-object owners, BaseVendor (#2609)
## Why Delta world saves re-serialize an entity only when it has been marked dirty. An audit of the generated classes found three ways serialized state changes without a mark; this PR closes the ones that do not need a new generator package. ## What - **Custom `[SerializableProperty]` setters mark dirty.** Twelve hand-written setters assigned their backing field without `this.MarkDirty()`. `PlagueBeastLord.OpenedBy` was an auto-property carrying the attribute with no backing field at all; it is now a generated field with the same name, order and command-property exposure. - **Generated sub-objects are linked to their owner.** Without a `[DirtyTrackingEntity]` member the generator emits setters that mark nothing. Eight entity-owned sub-objects now carry the link and receive the owner through the constructor the generator calls: `BOBFilter` (owner is `IEntity`: a `PlayerMobile` or a `BulkOrderBook`), `BOBLargeSubEntry`, `PuzzleChestSolution` and `PuzzleChestSolutionAndTime`, `TalismanAttribute` (the random factories now take the talisman), `VendorItem`, `PlayerBBMessage`, `RaffleEntry`, `ShardPollOption`. Migration schemas were regenerated with the pinned tool; the only change is the value rule argument becoming `DeserializationRequiresParent`. - **BaseVendor uses the generator; restock amounts are no longer persisted.** The only state it wrote was which buy entries had grown restock amounts, packed by index into the live `SBInfos` tables. Restock is transient now and rebuilds on load; version 1 records are read and discarded through the legacy path. Every vendor subclass now serializes through a generated chain. ## Generator 4.1.0 This PR adopts SerializationGenerator 4.1.0 (modernuo/SerializationGenerator#55): SG3019/SG3020 diagnostics, `[VolatileSerializedState]`, `StopXxx()` timer helpers, and owner-constructor preference for sub-objects (so dictionary values are constructed with their owner; the 4.0.0 relink fallback is gone). `PlayerVendor.v3.json` gains `DeserializationRequiresParent` for its `VendorItem` values so the migration content struct constructs them with their vendor. SG3019 is an error under `TreatWarningsAsErrors` and generator diagnostics ignore pragmas, so the five contexts that live in whole-file player-keyed persistences (`ChampionTitle`, `ChampionTitleContext`, `MurderContext`, `VirtueContext`, `JailRecord`) now carry a `[DirtyTrackingEntity]` link to their `PlayerMobile`, which is where they will live once those blobs move onto the player record. `JailSystem.EmptyRecord` keeps a null player (`[CanBeNull]`). `ChampionTitle` needs both a context and a player constructor because the generator resolves the rule against the containing type but emits the call with the parent field; a comment in the file records this. ## Wire format Unchanged. No version bumps except `BaseVendor` 1 to 2 (which now writes nothing of its own). Schema diffs are rule-argument only (`DeserializationRequiresParent`). ## Testing Server.Tests 848 passed, UOContent.Tests 759 passed.
This commit is contained in:
parent
a2c232f4a8
commit
84153fba58
49 changed files with 223 additions and 214 deletions
|
|
@ -74,13 +74,13 @@ public abstract partial class BasePlayerBB : Item, ISecurable
|
|||
|
||||
if (_greeting != null)
|
||||
{
|
||||
board.Greeting = new PlayerBBMessage(_greeting.Time, _greeting.Poster, _greeting.Message);
|
||||
board.Greeting = new PlayerBBMessage(board, _greeting.Time, _greeting.Poster, _greeting.Message);
|
||||
}
|
||||
|
||||
for (var i = 0; i < _messages.Count; i++)
|
||||
{
|
||||
var message = _messages[i];
|
||||
board.AddToMessages(new PlayerBBMessage(message.Time, message.Poster, message.Message));
|
||||
board.AddToMessages(new PlayerBBMessage(board, message.Time, message.Poster, message.Message));
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -176,7 +176,7 @@ public abstract partial class BasePlayerBB : Item, ISecurable
|
|||
|
||||
if (text.Length > 0)
|
||||
{
|
||||
var message = new PlayerBBMessage(Core.Now, from, text);
|
||||
var message = new PlayerBBMessage(board, Core.Now, from, text);
|
||||
|
||||
if (_greeting)
|
||||
{
|
||||
|
|
@ -265,6 +265,9 @@ public abstract partial class BasePlayerBB : Item, ISecurable
|
|||
[SerializationGenerator(0)]
|
||||
public partial class PlayerBBMessage
|
||||
{
|
||||
[DirtyTrackingEntity]
|
||||
private BasePlayerBB _board;
|
||||
|
||||
[SerializableField(0)]
|
||||
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
||||
private DateTime _time;
|
||||
|
|
@ -277,12 +280,11 @@ public partial class PlayerBBMessage
|
|||
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
||||
private string _message;
|
||||
|
||||
public PlayerBBMessage()
|
||||
{
|
||||
}
|
||||
public PlayerBBMessage(BasePlayerBB board) => _board = board;
|
||||
|
||||
public PlayerBBMessage(DateTime time, Mobile poster, string message)
|
||||
public PlayerBBMessage(BasePlayerBB board, DateTime time, Mobile poster, string message)
|
||||
{
|
||||
_board = board;
|
||||
_time = time;
|
||||
_poster = poster;
|
||||
_message = message;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue