fix(core): Cleans up uninitialized packets (#397)

- [X] Encapsulates/abstracts buffer cache checking
- [X] Changes mobile moving cache to use Span2D
This commit is contained in:
Kamron Batman 2021-01-09 14:10:29 -08:00 committed by GitHub
parent 0b9fb9c071
commit 8763be8a21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
18 changed files with 417 additions and 529 deletions

View file

@ -32,7 +32,7 @@ namespace Server.Network
return;
}
Span<byte> buffer = stackalloc byte[SoundPacketLength];
Span<byte> buffer = stackalloc byte[SoundPacketLength].InitializePacket();
CreateSoundEffect(buffer, soundID, target);
ns.Send(buffer);
@ -40,6 +40,11 @@ namespace Server.Network
public static void CreateSoundEffect(Span<byte> buffer, int soundID, IPoint3D target)
{
if (buffer[0] != 0)
{
return;
}
var writer = new SpanWriter(buffer);
writer.Write((byte)0x54); // Packet ID
writer.Write((byte)1); // flags
@ -57,6 +62,11 @@ namespace Server.Network
int explodeEffect, int explodeSound, Serial serial, int layer, int unknown
)
{
if (buffer[0] != 0)
{
return;
}
var writer = new SpanWriter(buffer);
writer.Write((byte)0xC7); // Packet ID
writer.Write((byte)type);
@ -168,6 +178,11 @@ namespace Server.Network
int speed, int duration, bool fixedDirection, bool explode, int hue, int renderMode
)
{
if (buffer[0] != 0)
{
return;
}
var writer = new SpanWriter(buffer);
writer.Write((byte)0xC0); // Packet ID
writer.Write((byte)type);