warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Eliminates double lookup with Contains->Remove (#2539)

Browse source
This commit is contained in:
Kamron Batman 2026-07-19 09:26:27 -07:00 • committed by GitHub
parent e12cc5dd83
commit 8d88ef70fd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 25 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Projects/UOContent/Engines/Factions/Items/Traps/BaseFactionTrap.cs
View file

@ -252,11 +252,7 @@ public abstract class BaseFactionTrap : BaseTrap
public override void OnDelete()
{
if (Faction?.Traps.Contains(this) == true)
{
Faction.Traps.Remove(this);
}
Faction?.Traps.Remove(this);
base.OnDelete();
}
@ -286,4 +282,4 @@ public abstract class BaseFactionTrap : BaseTrap
return faction != Faction;
}
}
}