warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes random bias & Adds back champion arties for UOML (#1235)

Browse source 
* Fixes RNG bias, we should never do `Utility.RandomDouble() <=`
* Adds back champion artifacts behind UOML flag.
This commit is contained in:
Kamron Batman 2022-11-09 16:33:27 -08:00 • committed by GitHub
parent 810061db8c
commit 8e01db8555
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
60 changed files with 289 additions and 335 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Projects/UOContent/Mobiles/BaseCreature.cs
View file

@ -2995,7 +2995,7 @@ namespace Server.Mobiles
{
PackItem(new ParagonChest(Name, treasureLevel));
}
else if ((Map == Map.Felucca || Map == Map.Trammel) && Utility.RandomDouble() <= TreasureMap.LootChance)
else if ((Map == Map.Felucca || Map == Map.Trammel) && Utility.RandomDouble() < TreasureMap.LootChance)
{
PackItem(new TreasureMap(treasureLevel, Map));
}
@ -4222,7 +4222,7 @@ namespace Server.Mobiles
{
for (var i = 0; i < amount; ++i)
{
if (m_Loyalty < MaxLoyalty && Utility.RandomDouble() <= 0.5)
if (m_Loyalty < MaxLoyalty && Utility.RandomBool())
{
m_Loyalty += 10;
}
@ -4799,7 +4799,7 @@ namespace Server.Mobiles
public void PackNecroScroll(int index)
{
if (!Core.AOS || Utility.RandomDouble() >= 0.05)
if (!Core.AOS || Utility.RandomDouble() < 0.95)
{
return;
}