warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes random bias & Adds back champion arties for UOML (#1235)

Browse source 
* Fixes RNG bias, we should never do `Utility.RandomDouble() <=`
* Adds back champion artifacts behind UOML flag.
This commit is contained in:
Kamron Batman 2022-11-09 16:33:27 -08:00 • committed by GitHub
parent 810061db8c
commit 8e01db8555
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
60 changed files with 289 additions and 335 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Projects/UOContent/Skills/AnimalTaming.cs
View file

@ -206,7 +206,7 @@ namespace Server.SkillHandlers
// Someone else is already taming this.
creature.PrivateOverheadMessage(MessageType.Regular, 0x3B2, 502802, from.NetState);
}
else if (creature.CanAngerOnTame && Utility.RandomDouble() <= 0.95)
else if (creature.CanAngerOnTame && Utility.RandomDouble() < 0.95)
{
// You seem to anger the beast!
creature.PrivateOverheadMessage(MessageType.Regular, 0x3B2, 502805, from.NetState);
@ -214,7 +214,7 @@ namespace Server.SkillHandlers
creature.PlaySound(creature.GetAngerSound());
creature.Direction = creature.GetDirectionTo(from);
if (creature.BardPacified && Utility.RandomDouble() > .24)
if (creature.BardPacified && Utility.RandomDouble() < 0.75)
{
Timer.StartTimer(TimeSpan.FromSeconds(2.0), () => Pacify(creature));
}

4
Projects/UOContent/Skills/SpiritSpeak.cs
View file

@ -161,7 +161,9 @@ namespace Server.SkillHandlers
{
Caster.CheckSkill(SkillName.SpiritSpeak, 0.0, 120.0);
if (Utility.RandomDouble() > Caster.Skills.SpiritSpeak.Value / 100.0)
var skill = Caster.Skills.SpiritSpeak.Value;
if (skill < 100.0 && Utility.RandomDouble() >= skill / 100.0)
{
Caster.SendLocalizedMessage(502443); // You fail your attempt at contacting the netherworld.
}