warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Optimizes TextDefinition to eliminate allocations. Removes TextDefinition ctor. (#1221)

Browse source 
### BREAKING CHANGE ###
The constructor for `TextDefinition` has been removed. Instead use `TextDefinition.Of()` or cast the integer/string to TextDefinition.
This commit is contained in:
Kamron Batman 2022-10-30 16:53:23 -07:00 • committed by GitHub
parent 213b7025af
commit 910e06767b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
50 changed files with 790 additions and 722 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Projects/Server.Tests/Tests/Text/TextDefinitionTests.cs Normal file
View file

@ -0,0 +1,30 @@
using System;
using Xunit;
namespace Server.Tests;
public class TextDefinitionTests
{
[Theory]
[InlineData(10345, "", "#10345")]
[InlineData(0, "Hello", "Hello")]
[InlineData(10345, "Hello", "#10345")]
public void TestTextDefinitionToString(int a1, string a2, string expected)
{
Assert.Equal(expected, TextDefinition.Of(a1, a2).ToString());
}
[Theory]
[InlineData(10345, "", 10345, "", true)]
[InlineData(10345, "", 0, "Hello", false)]
[InlineData(0, "Hello", 0, "Hello", true)]
[InlineData(0, "Hello", 0, "hello", false)]
[InlineData(10345, "Hello", 10345, "Goodbye", true)]
[InlineData(10345, "Hello", 10510, "Hello", false)]
public void TestTextDefinitionIsEqual(int a1, string a2, int b1, string b2, bool isEqual)
{
var a = TextDefinition.Of(a1, a2);
var b = TextDefinition.Of(b1, b2);
Assert.Equal(isEqual, a.Equals(b));
}
}