warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Optimizes TextDefinition to eliminate allocations. Removes TextDefinition ctor. (#1221)

Browse source 
### BREAKING CHANGE ###
The constructor for `TextDefinition` has been removed. Instead use `TextDefinition.Of()` or cast the integer/string to TextDefinition.
This commit is contained in:
Kamron Batman 2022-10-30 16:53:23 -07:00 • committed by GitHub
parent 213b7025af
commit 910e06767b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
50 changed files with 790 additions and 722 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Projects/UOContent/Engines/Craft/Core/CraftSystem.cs
View file

@ -50,7 +50,7 @@ namespace Server.Engines.Craft
public abstract SkillName MainSkill { get; }
public virtual TextDefinition GumpTitle => 0;
public virtual TextDefinition GumpTitle => TextDefinition.Empty;
public virtual CraftECA ECA => CraftECA.ChanceMinusSixty;

2
Projects/UOContent/Engines/Craft/Core/Recipes.cs
View file

@ -33,7 +33,7 @@ public class Recipe
public int ID { get; }
public TextDefinition TextDefinition => _td ??= new TextDefinition(CraftItem.NameNumber, CraftItem.NameString);
public TextDefinition TextDefinition => _td ??= TextDefinition.Of(CraftItem.NameNumber, CraftItem.NameString);
public static void Initialize()
{

2
Projects/UOContent/Engines/Craft/DefAlchemy.cs
View file

@ -18,7 +18,7 @@ public class DefAlchemy : CraftSystem
public override SkillName MainSkill => SkillName.Alchemy;
public override TextDefinition GumpTitle => 1044001;
public override TextDefinition GumpTitle { get; } = 1044001;
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefBlacksmithy.cs
View file

@ -19,7 +19,7 @@ public class DefBlacksmithy : CraftSystem
public override SkillName MainSkill => SkillName.Blacksmith;
public override TextDefinition GumpTitle => 1044002;
public override TextDefinition GumpTitle { get; } = 1044002;
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefBowFletching.cs
View file

@ -16,7 +16,7 @@ public class DefBowFletching : CraftSystem
public override SkillName MainSkill => SkillName.Fletching;
public override TextDefinition GumpTitle => 1044006;
public override TextDefinition GumpTitle { get; } = 1044006;
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefCarpentry.cs
View file

@ -16,7 +16,7 @@ public class DefCarpentry : CraftSystem
public override SkillName MainSkill => SkillName.Carpentry;
public override TextDefinition GumpTitle => 1044004;
public override TextDefinition GumpTitle { get; } = 1044004;
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefCartography.cs
View file

@ -16,7 +16,7 @@ public class DefCartography : CraftSystem
public override SkillName MainSkill => SkillName.Cartography;
public override TextDefinition GumpTitle => 1044008;
public override TextDefinition GumpTitle { get; } = 1044008;
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefCooking.cs
View file

@ -16,7 +16,7 @@ public class DefCooking : CraftSystem
public override SkillName MainSkill => SkillName.Cooking;
public override TextDefinition GumpTitle => 1044003;
public override TextDefinition GumpTitle { get; } = 1044003;
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefGlassblowing.cs
View file

@ -17,7 +17,7 @@ public class DefGlassblowing : CraftSystem
public override SkillName MainSkill => SkillName.Alchemy;
public override TextDefinition GumpTitle => 1044622;
public override TextDefinition GumpTitle { get; } = 1044622;
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefInscription.cs
View file

@ -36,7 +36,7 @@ public class DefInscription : CraftSystem
public override SkillName MainSkill => SkillName.Inscribe;
public override TextDefinition GumpTitle => 1044009;
public override TextDefinition GumpTitle { get; } = 1044009;
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefMasonry.cs
View file

@ -17,7 +17,7 @@ public class DefMasonry : CraftSystem
public override SkillName MainSkill => SkillName.Carpentry;
public override TextDefinition GumpTitle => 1044500;
public override TextDefinition GumpTitle { get; } = 1044500;
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefTailoring.cs
View file

@ -24,7 +24,7 @@ public class DefTailoring : CraftSystem
public override SkillName MainSkill => SkillName.Tailoring;
public override TextDefinition GumpTitle => 1044005; // Tailoring Menu
public override TextDefinition GumpTitle { get; } = 1044005; // Tailoring Menu
public static CraftSystem CraftSystem { get; private set; }

2
Projects/UOContent/Engines/Craft/DefTinkering.cs
View file

@ -32,7 +32,7 @@ public class DefTinkering : CraftSystem
public override SkillName MainSkill => SkillName.Tinkering;
public override TextDefinition GumpTitle => 1044007;
public override TextDefinition GumpTitle { get; } = 1044007;
public static CraftSystem CraftSystem { get; private set; }