warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Optimizes TextDefinition to eliminate allocations. Removes TextDefinition ctor. (#1221)

Browse source 
### BREAKING CHANGE ###
The constructor for `TextDefinition` has been removed. Instead use `TextDefinition.Of()` or cast the integer/string to TextDefinition.
This commit is contained in:
Kamron Batman 2022-10-30 16:53:23 -07:00 • committed by GitHub
parent 213b7025af
commit 910e06767b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
50 changed files with 790 additions and 722 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Projects/UOContent/Engines/Craft/Core/CraftSystem.cs
View file

@ -50,7 +50,7 @@ namespace Server.Engines.Craft
public abstract SkillName MainSkill { get; }
public virtual TextDefinition GumpTitle => 0;
public virtual TextDefinition GumpTitle => TextDefinition.Empty;
public virtual CraftECA ECA => CraftECA.ChanceMinusSixty;

2
Projects/UOContent/Engines/Craft/Core/Recipes.cs
View file

@ -33,7 +33,7 @@ public class Recipe
public int ID { get; }
public TextDefinition TextDefinition => _td ??= new TextDefinition(CraftItem.NameNumber, CraftItem.NameString);
public TextDefinition TextDefinition => _td ??= TextDefinition.Of(CraftItem.NameNumber, CraftItem.NameString);
public static void Initialize()
{