warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Optimizes TextDefinition to eliminate allocations. Removes TextDefinition ctor. (#1221)

Browse source 
### BREAKING CHANGE ###
The constructor for `TextDefinition` has been removed. Instead use `TextDefinition.Of()` or cast the integer/string to TextDefinition.
This commit is contained in:
Kamron Batman 2022-10-30 16:53:23 -07:00 • committed by GitHub
parent 213b7025af
commit 910e06767b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
50 changed files with 790 additions and 722 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Projects/UOContent/Gumps/Guilds/New Guild System/GuildRosterGump.cs
View file

@ -70,9 +70,7 @@ namespace Server.Guilds
defs[0] = name;
defs[1] = pm.GuildRank.Name;
defs[2] = pm.NetState != null
? new TextDefinition(1063015)
: new TextDefinition(pm.LastOnline.ToString("yyyy-MM-dd"));
defs[2] = pm.NetState != null ? 1063015 : pm.LastOnline.ToString("yyyy-MM-dd");
defs[3] = pm.GuildTitle ?? "";
return defs;
@ -151,8 +149,8 @@ namespace Server.Guilds
{
pm.SendLocalizedMessage(1063051, targ.Name); // ~1_val~ is already a member of a guild.
}
else if (targ.HasGump<BaseGuildGump>() || targ.HasGump<CreateGuildGump>()
) // TODO: Check message if CreateGuildGump Open
// TODO: Check message if CreateGuildGump Open
else if (targ.HasGump<BaseGuildGump>() || targ.HasGump<CreateGuildGump>())
{
pm.SendLocalizedMessage(1063052, targ.Name); // ~1_val~ is currently considering another guild invitation.
}