warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Optimizes TextDefinition to eliminate allocations. Removes TextDefinition ctor. (#1221)

Browse source 
### BREAKING CHANGE ###
The constructor for `TextDefinition` has been removed. Instead use `TextDefinition.Of()` or cast the integer/string to TextDefinition.
This commit is contained in:
Kamron Batman 2022-10-30 16:53:23 -07:00 • committed by GitHub
parent 213b7025af
commit 910e06767b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
50 changed files with 790 additions and 722 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Projects/UOContent/Spells/Ninjitsu/Backstab.cs
View file

@ -8,8 +8,8 @@ namespace Server.Spells.Ninjitsu
public override int BaseMana => 30;
public override double RequiredSkill => Core.ML ? 40.0 : 20.0;
public override TextDefinition AbilityMessage =>
new(1063089); // You prepare to Backstab your opponent.
// You prepare to Backstab your opponent.
public override TextDefinition AbilityMessage { get; } = 1063089;
public override bool ValidatesDuringHit => false;

4
Projects/UOContent/Spells/Ninjitsu/DeathStrike.cs
View file

@ -13,8 +13,8 @@ namespace Server.Spells.Ninjitsu
public override int BaseMana => 30;
public override double RequiredSkill => 85.0;
public override TextDefinition AbilityMessage =>
new(1063091); // You prepare to hit your opponent with a Death Strike.
// You prepare to hit your opponent with a Death Strike.
public override TextDefinition AbilityMessage { get; } = 1063091;
public override double GetDamageScalar(Mobile attacker, Mobile defender) => 0.5;

4
Projects/UOContent/Spells/Ninjitsu/FocusAttack.cs
View file

@ -7,8 +7,8 @@ namespace Server.Spells.Ninjitsu
public override int BaseMana => Core.ML ? 10 : 20;
public override double RequiredSkill => Core.ML ? 30.0 : 60;
public override TextDefinition AbilityMessage =>
new(1063095); // You prepare to focus all of your abilities into your next strike.
// You prepare to focus all of your abilities into your next strike.
public override TextDefinition AbilityMessage { get; } = 1063095;
public override bool Validate(Mobile from)
{

4
Projects/UOContent/Spells/Ninjitsu/KiAttack.cs
View file

@ -11,8 +11,8 @@ namespace Server.Spells.Ninjitsu
public override int BaseMana => 25;
public override double RequiredSkill => 80.0;
public override TextDefinition AbilityMessage =>
new(1063099); // Your Ki Attack must be complete within 2 seconds for the damage bonus!
// Your Ki Attack must be complete within 2 seconds for the damage bonus!
public override TextDefinition AbilityMessage { get; } = 1063099;
public override void OnUse(Mobile from)
{

2
Projects/UOContent/Spells/Ninjitsu/SurpriseAttack.cs
View file

@ -11,7 +11,7 @@ namespace Server.Spells.Ninjitsu
public override int BaseMana => 20;
public override double RequiredSkill => Core.ML ? 60.0 : 30.0;
public override TextDefinition AbilityMessage => new(1063128); // You prepare to surprise your prey.
public override TextDefinition AbilityMessage { get; } = 1063128; // You prepare to surprise your prey.
public override bool ValidatesDuringHit => false;