Fixes code according to modern code style. Fixes a few expression bugs.

This commit is contained in:
Kamron Batman 2018-09-15 09:58:51 -07:00
parent 89eea25e5f
commit 970fd563b2
3324 changed files with 441118 additions and 433755 deletions

View file

@ -3,277 +3,271 @@ using System.Collections.Generic;
namespace Server.Factions
{
public class FactionState
{
private Faction m_Faction;
private Mobile m_Commander;
public class FactionState
{
private const int BroadcastsPerPeriod = 2;
private static readonly TimeSpan BroadcastPeriod = TimeSpan.FromHours(1.0);
private Mobile m_Commander;
private Faction m_Faction;
private DateTime[] m_LastBroadcasts = new DateTime[BroadcastsPerPeriod];
public FactionState(Faction faction)
{
m_Faction = faction;
Tithe = 50;
Members = new List<PlayerState>();
Election = new Election(faction);
FactionItems = new List<FactionItem>();
Traps = new List<BaseFactionTrap>();
}
public FactionState(GenericReader reader)
{
int version = reader.ReadEncodedInt();
switch (version)
{
case 5:
{
LastAtrophy = reader.ReadDateTime();
goto case 4;
}
case 4:
{
int count = reader.ReadEncodedInt();
for (int i = 0; i < count; ++i)
{
DateTime time = reader.ReadDateTime();
if (i < m_LastBroadcasts.Length)
m_LastBroadcasts[i] = time;
}
goto case 3;
}
case 3:
case 2:
case 1:
{
Election = new Election(reader);
goto case 0;
}
case 0:
{
m_Faction = Faction.ReadReference(reader);
m_Commander = reader.ReadMobile();
if (version < 5)
LastAtrophy = DateTime.UtcNow;
if (version < 4)
{
DateTime time = reader.ReadDateTime();
if (m_LastBroadcasts.Length > 0)
m_LastBroadcasts[0] = time;
}
private const int BroadcastsPerPeriod = 2;
private static readonly TimeSpan BroadcastPeriod = TimeSpan.FromHours( 1.0 );
Tithe = reader.ReadEncodedInt();
Silver = reader.ReadEncodedInt();
private DateTime[] m_LastBroadcasts = new DateTime[BroadcastsPerPeriod];
int memberCount = reader.ReadEncodedInt();
public DateTime LastAtrophy { get; set; }
Members = new List<PlayerState>();
public bool FactionMessageReady
{
get
{
for ( int i = 0; i < m_LastBroadcasts.Length; ++i )
{
if ( DateTime.UtcNow >= (m_LastBroadcasts[i] + BroadcastPeriod) )
return true;
}
return false;
}
}
public bool IsAtrophyReady => DateTime.UtcNow >= (LastAtrophy + TimeSpan.FromHours( 47.0 ));
public int CheckAtrophy()
{
if ( DateTime.UtcNow < (LastAtrophy + TimeSpan.FromHours( 47.0 )) )
return 0;
int distrib = 0;
LastAtrophy = DateTime.UtcNow;
List<PlayerState> members = new List<PlayerState>( Members );
for ( int i = 0; i < members.Count; ++i )
{
PlayerState ps = members[i];
if ( ps.IsActive )
{
ps.IsActive = false;
continue;
}
if ( ps.KillPoints > 0 )
{
int atrophy = ( ps.KillPoints + 9 ) / 10;
ps.KillPoints -= atrophy;
distrib += atrophy;
}
}
return distrib;
}
public void RegisterBroadcast()
{
for ( int i = 0; i < m_LastBroadcasts.Length; ++i )
{
if ( DateTime.UtcNow >= (m_LastBroadcasts[i] + BroadcastPeriod) )
{
m_LastBroadcasts[i] = DateTime.UtcNow;
break;
}
}
}
public List<FactionItem> FactionItems { get; set; }
public List<BaseFactionTrap> Traps { get; set; }
public Election Election { get; set; }
public Mobile Commander
{
get => m_Commander;
set
{
m_Commander?.InvalidateProperties();
m_Commander = value;
if ( m_Commander != null )
{
m_Commander.SendLocalizedMessage( 1042227 ); // You have been elected Commander of your faction
m_Commander.InvalidateProperties();
PlayerState pl = PlayerState.Find( m_Commander );
if ( pl?.Finance != null )
pl.Finance.Finance = null;
if ( pl?.Sheriff != null )
pl.Sheriff.Sheriff = null;
}
}
}
public int Tithe { get; set; }
for (int i = 0; i < memberCount; ++i)
{
PlayerState pl = new PlayerState(reader, m_Faction, Members);
public int Silver { get; set; }
public List<PlayerState> Members { get; set; }
public FactionState( Faction faction )
{
m_Faction = faction;
Tithe = 50;
Members = new List<PlayerState>();
Election = new Election( faction );
FactionItems = new List<FactionItem>();
Traps = new List<BaseFactionTrap>();
}
if (pl.Mobile != null)
Members.Add(pl);
}
public FactionState( GenericReader reader )
{
int version = reader.ReadEncodedInt();
switch ( version )
{
case 5:
{
LastAtrophy = reader.ReadDateTime();
goto case 4;
}
case 4:
{
int count = reader.ReadEncodedInt();
for ( int i = 0; i < count; ++i )
{
DateTime time = reader.ReadDateTime();
if ( i < m_LastBroadcasts.Length )
m_LastBroadcasts[i] = time;
}
m_Faction.State = this;
goto case 3;
}
case 3:
case 2:
case 1:
{
Election = new Election( reader );
m_Faction.ZeroRankOffset = Members.Count;
Members.Sort();
goto case 0;
}
case 0:
{
m_Faction = Faction.ReadReference( reader );
for (int i = Members.Count - 1; i >= 0; i--)
{
PlayerState player = Members[i];
m_Commander = reader.ReadMobile();
if (player.KillPoints <= 0)
m_Faction.ZeroRankOffset = i;
else
player.RankIndex = i;
}
if ( version < 5 )
LastAtrophy = DateTime.UtcNow;
FactionItems = new List<FactionItem>();
if ( version < 4 )
{
DateTime time = reader.ReadDateTime();
if (version >= 2)
{
int factionItemCount = reader.ReadEncodedInt();
if ( m_LastBroadcasts.Length > 0 )
m_LastBroadcasts[0] = time;
}
for (int i = 0; i < factionItemCount; ++i)
{
FactionItem factionItem = new FactionItem(reader, m_Faction);
Tithe = reader.ReadEncodedInt();
Silver = reader.ReadEncodedInt();
Timer.DelayCall(TimeSpan.Zero, factionItem.CheckAttach); // sandbox attachment
}
}
int memberCount = reader.ReadEncodedInt();
Traps = new List<BaseFactionTrap>();
Members = new List<PlayerState>();
if (version >= 3)
{
int factionTrapCount = reader.ReadEncodedInt();
for ( int i = 0; i < memberCount; ++i )
{
PlayerState pl = new PlayerState( reader, m_Faction, Members );
for (int i = 0; i < factionTrapCount; ++i)
if (reader.ReadItem() is BaseFactionTrap trap && !trap.CheckDecay())
Traps.Add(trap);
}
if ( pl.Mobile != null )
Members.Add( pl );
}
break;
}
}
m_Faction.State = this;
if (version < 1)
Election = new Election(m_Faction);
}
m_Faction.ZeroRankOffset = Members.Count;
Members.Sort();
public DateTime LastAtrophy{ get; set; }
for ( int i = Members.Count - 1; i >= 0; i-- ) {
PlayerState player = Members[i];
public bool FactionMessageReady
{
get
{
for (int i = 0; i < m_LastBroadcasts.Length; ++i)
if (DateTime.UtcNow >= m_LastBroadcasts[i] + BroadcastPeriod)
return true;
if ( player.KillPoints <= 0 )
m_Faction.ZeroRankOffset = i;
else
player.RankIndex = i;
}
return false;
}
}
FactionItems = new List<FactionItem>();
public bool IsAtrophyReady => DateTime.UtcNow >= LastAtrophy + TimeSpan.FromHours(47.0);
if ( version >= 2 )
{
int factionItemCount = reader.ReadEncodedInt();
public List<FactionItem> FactionItems{ get; set; }
for ( int i = 0; i < factionItemCount; ++i )
{
FactionItem factionItem = new FactionItem( reader, m_Faction );
public List<BaseFactionTrap> Traps{ get; set; }
Timer.DelayCall( TimeSpan.Zero, factionItem.CheckAttach ); // sandbox attachment
}
}
public Election Election{ get; set; }
Traps = new List<BaseFactionTrap>();
public Mobile Commander
{
get => m_Commander;
set
{
m_Commander?.InvalidateProperties();
if ( version >= 3 )
{
int factionTrapCount = reader.ReadEncodedInt();
m_Commander = value;
for ( int i = 0; i < factionTrapCount; ++i )
{
if ( reader.ReadItem() is BaseFactionTrap trap && !trap.CheckDecay() )
Traps.Add( trap );
}
}
if (m_Commander != null)
{
m_Commander.SendLocalizedMessage(1042227); // You have been elected Commander of your faction
break;
}
}
m_Commander.InvalidateProperties();
if ( version < 1 )
Election = new Election( m_Faction );
}
PlayerState pl = PlayerState.Find(m_Commander);
public void Serialize( GenericWriter writer )
{
writer.WriteEncodedInt( (int) 5 ); // version
if (pl?.Finance != null)
pl.Finance.Finance = null;
writer.Write( LastAtrophy );
if (pl?.Sheriff != null)
pl.Sheriff.Sheriff = null;
}
}
}
writer.WriteEncodedInt( (int) m_LastBroadcasts.Length );
public int Tithe{ get; set; }
for ( int i = 0; i < m_LastBroadcasts.Length; ++i )
writer.Write( (DateTime) m_LastBroadcasts[i] );
public int Silver{ get; set; }
Election.Serialize( writer );
public List<PlayerState> Members{ get; set; }
Faction.WriteReference( writer, m_Faction );
public int CheckAtrophy()
{
if (DateTime.UtcNow < LastAtrophy + TimeSpan.FromHours(47.0))
return 0;
writer.Write( (Mobile) m_Commander );
int distrib = 0;
LastAtrophy = DateTime.UtcNow;
writer.WriteEncodedInt( (int) Tithe );
writer.WriteEncodedInt( (int) Silver );
List<PlayerState> members = new List<PlayerState>(Members);
writer.WriteEncodedInt( (int) Members.Count );
for (int i = 0; i < members.Count; ++i)
{
PlayerState ps = members[i];
for ( int i = 0; i < Members.Count; ++i )
{
PlayerState pl = (PlayerState) Members[i];
if (ps.IsActive)
{
ps.IsActive = false;
continue;
}
pl.Serialize( writer );
}
if (ps.KillPoints > 0)
{
int atrophy = (ps.KillPoints + 9) / 10;
ps.KillPoints -= atrophy;
distrib += atrophy;
}
}
writer.WriteEncodedInt( (int) FactionItems.Count );
return distrib;
}
for ( int i = 0; i < FactionItems.Count; ++i )
FactionItems[i].Serialize( writer );
public void RegisterBroadcast()
{
for (int i = 0; i < m_LastBroadcasts.Length; ++i)
if (DateTime.UtcNow >= m_LastBroadcasts[i] + BroadcastPeriod)
{
m_LastBroadcasts[i] = DateTime.UtcNow;
break;
}
}
writer.WriteEncodedInt( (int) Traps.Count );
public void Serialize(GenericWriter writer)
{
writer.WriteEncodedInt(5); // version
for ( int i = 0; i < Traps.Count; ++i )
writer.Write( (Item) Traps[i] );
}
}
}
writer.Write(LastAtrophy);
writer.WriteEncodedInt(m_LastBroadcasts.Length);
for (int i = 0; i < m_LastBroadcasts.Length; ++i)
writer.Write(m_LastBroadcasts[i]);
Election.Serialize(writer);
Faction.WriteReference(writer, m_Faction);
writer.Write(m_Commander);
writer.WriteEncodedInt(Tithe);
writer.WriteEncodedInt(Silver);
writer.WriteEncodedInt(Members.Count);
for (int i = 0; i < Members.Count; ++i)
{
PlayerState pl = Members[i];
pl.Serialize(writer);
}
writer.WriteEncodedInt(FactionItems.Count);
for (int i = 0; i < FactionItems.Count; ++i)
FactionItems[i].Serialize(writer);
writer.WriteEncodedInt(Traps.Count);
for (int i = 0; i < Traps.Count; ++i)
writer.Write(Traps[i]);
}
}
}