fix: LastMoved and stat-gain stamps stay absolute across restarts (#2729)

ReadAnchoredTime shifted Item.LastMoved, Item.DecayResetTime and
Mobile.LastStr/Int/DexGain forward by the downtime at load. The bytes
were stable from save to save, but the first save after every restart
rewrote one timestamp in nearly every item record and most mobile
records, which defeats any per-record backup or delta save.

- LastMoved and DecayResetTime are read as saved. The downtime credit
  is applied after load by Item.CreditDowntimeToDecay, which moves
  DecayResetTime only for items whose decay countdown was still running
  when the save started. Every other item keeps its bytes, and decay
  timing is unchanged.
- World.LoadedSaveStartTime exposes the loaded save's anchor so the
  credit can tell which countdowns were running.
- Stat-gain stamps are read raw. The cooldown is minutes long, so
  downtime counting toward it costs nothing.

No format change: these fields were already absolute ticks.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kamron Batman 2026-10-25 16:27:12 -07:00 • committed by GitHub
parent ab59efea86
commit 9af7dd555a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 157 additions and 12 deletions

View file

@ -82,4 +82,112 @@ public class AnchoredItemSerializationTests
restored?.Delete();
}
}
/// <summary>
/// LastMoved is the real time of the move, so a load after downtime must not shift it.
/// Shifting it rewrote every item record on the first save after every restart.
/// </summary>
[Fact]
public void LastMoved_IsNotShiftedByTheLoadAnchor()
{
var item = new Item(0x1F13);
var moved = Core.Now - TimeSpan.FromDays(30);
item.LastMoved = moved;
var restored = new Item((Serial)0x7ffff124u);
restored.Deserialize(new BufferReader(SerializeItem(item)) { AnchoredTimeShift = TimeSpan.FromHours(2) });
Assert.Equal(moved, restored.LastMoved);
Assert.Equal(default(DateTime), restored.DecayResetTime);
item.Delete();
restored.Delete();
}
/// <summary>
/// Downtime still does not count toward decay: a countdown running when the save started
/// resumes with the time it had left, carried by DecayResetTime.
/// </summary>
[Fact]
public void Downtime_IsCreditedToARunningDecayCountdown()
{
var start = Core._now;
try
{
var item = new Item(0x1F13);
item.LastMoved = start - TimeSpan.FromMinutes(10);
var deadline = item.ScheduledDecayTime;
var downtime = TimeSpan.FromHours(2);
Core._now = start + downtime;
item.CreditDowntimeToDecay(start, downtime);
Assert.Equal(start - TimeSpan.FromMinutes(10), item.LastMoved);
Assert.Equal(deadline + downtime, item.ScheduledDecayTime);
item.Delete();
}
finally
{
Core._now = start;
}
}
/// <summary>
/// The common case: an item whose countdown had already run out gets no credit, so a restart
/// leaves its record byte-identical.
/// </summary>
[Fact]
public void ItemAlreadyDueAtSave_GetsNoCredit_AndKeepsItsBytes()
{
var start = Core._now;
try
{
var item = new Item(0x1F13);
item.LastMoved = start - TimeSpan.FromDays(3);
var before = SerializeItem(item);
var downtime = TimeSpan.FromMinutes(30);
Core._now = start + downtime;
item.CreditDowntimeToDecay(start, downtime);
Assert.Equal(default(DateTime), item.DecayResetTime);
Assert.Equal(before, SerializeItem(item));
item.Delete();
}
finally
{
Core._now = start;
}
}
/// <summary>
/// Stat-gain stamps are absolute and not shifted at load either; downtime counts toward a
/// cooldown that is only minutes long.
/// </summary>
[Fact]
public void StatGainStamps_AreNotShiftedByTheLoadAnchor()
{
var mobile = new Mobile(World.NewMobile);
mobile.DefaultMobileInit();
mobile.LastStrGain = Core.Now - TimeSpan.FromMinutes(3);
mobile.LastIntGain = Core.Now - TimeSpan.FromMinutes(2);
mobile.LastDexGain = Core.Now - TimeSpan.FromMinutes(1);
var writer = new BufferWriter(new byte[4096], true);
mobile.Serialize(writer);
var restored = new Mobile(World.NewMobile);
restored.Deserialize(new BufferReader(writer.Buffer[..(int)writer.Position]) { AnchoredTimeShift = TimeSpan.FromHours(2) });
Assert.Equal(mobile.LastStrGain, restored.LastStrGain);
Assert.Equal(mobile.LastIntGain, restored.LastIntGain);
Assert.Equal(mobile.LastDexGain, restored.LastDexGain);
mobile.Delete();
restored.Delete();
}
}