fix: Fixes dupe property copying. Adds IgnoreDupe (#1811)
## Summary ### Changes - Adds `[IgnoreDupe]` and `[SerializedIgnoreDupe]` - Updates all _known_ classes that need the attribute. Some might be missing, please helps us find them! - Adds `Item.Dupe()` command and encapsulates `CopyProperties` and `OnAfterDuped`. This is also overridable. - Updates Dupe command to use the new logic. - Fixes duping multiple kinds of objects that used to be outright broken. ### Bug Fixes - Fixes issue with durability after duping - Fixes issue with hue after duping > [!Note] > **Developer Note** > Customizing how duping an item works now requires two steps: > 1. Add `[IgnoreDupe]` or `[SerializedIgnoreDupe]` to the property/field > 2. Add custom logic in an `OnAfterDuped` override > > When do you need to do this? > *When the property being copied is not a primitive, and you need to manually deep-clone the contents of the property such as with Lists, Dictionaries, or sub classes.*
This commit is contained in:
parent
a8d3d2773e
commit
9c7cb5d778
34 changed files with 502 additions and 248 deletions
|
|
@ -11,6 +11,7 @@ namespace Server.Items
|
|||
[SerializationGenerator(5, false)]
|
||||
public partial class BaseBook : Item, ISecurable
|
||||
{
|
||||
[SerializedIgnoreDupe]
|
||||
[SerializableField(0)]
|
||||
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
||||
private SecureLevel _level;
|
||||
|
|
@ -45,6 +46,7 @@ namespace Server.Items
|
|||
[SerializableFieldSaveFlag(3)]
|
||||
private bool ShouldSerializeWritable() => _writable;
|
||||
|
||||
[SerializedIgnoreDupe]
|
||||
[SerializableField(4, setter: "protected")]
|
||||
private BookPageInfo[] _pages;
|
||||
|
||||
|
|
@ -52,7 +54,7 @@ namespace Server.Items
|
|||
private bool ShouldSerializePages() => DefaultContent?.IsMatch(_pages) != true;
|
||||
|
||||
[SerializableFieldDefault(4)]
|
||||
private BookPageInfo[] PagesDefaultvalue() => DefaultContent?.Copy() ?? Array.Empty<BookPageInfo>();
|
||||
private BookPageInfo[] PagesDefaultValue() => DefaultContent?.Copy() ?? Array.Empty<BookPageInfo>();
|
||||
|
||||
[Constructible]
|
||||
public BaseBook(int itemID, int pageCount = 20, bool writable = true) : this(itemID, null, null, pageCount, writable)
|
||||
|
|
@ -91,6 +93,29 @@ namespace Server.Items
|
|||
[CommandProperty(AccessLevel.GameMaster)]
|
||||
public int PagesCount => _pages.Length;
|
||||
|
||||
public override void OnAfterDuped(Item newItem)
|
||||
{
|
||||
if (newItem is not BaseBook book)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
book.Pages = new BookPageInfo[book.PagesCount];
|
||||
|
||||
for (var i = 0; i < _pages.Length; ++i)
|
||||
{
|
||||
var oldPage = _pages[i];
|
||||
var oldLines = _pages[i].Lines;
|
||||
var lines = new string[oldPage.Lines.Length];
|
||||
for (var j = 0; j < oldLines.Length; j++)
|
||||
{
|
||||
lines[j] = oldLines[j];
|
||||
}
|
||||
|
||||
book._pages[i] = new BookPageInfo(lines);
|
||||
}
|
||||
}
|
||||
|
||||
public virtual BookContent DefaultContent => null;
|
||||
|
||||
public string ContentAsString
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue