fix: Fixes dupe property copying. Adds IgnoreDupe (#1811)
## Summary ### Changes - Adds `[IgnoreDupe]` and `[SerializedIgnoreDupe]` - Updates all _known_ classes that need the attribute. Some might be missing, please helps us find them! - Adds `Item.Dupe()` command and encapsulates `CopyProperties` and `OnAfterDuped`. This is also overridable. - Updates Dupe command to use the new logic. - Fixes duping multiple kinds of objects that used to be outright broken. ### Bug Fixes - Fixes issue with durability after duping - Fixes issue with hue after duping > [!Note] > **Developer Note** > Customizing how duping an item works now requires two steps: > 1. Add `[IgnoreDupe]` or `[SerializedIgnoreDupe]` to the property/field > 2. Add custom logic in an `OnAfterDuped` override > > When do you need to do this? > *When the property being copied is not a primitive, and you need to manually deep-clone the contents of the property such as with Lists, Dictionaries, or sub classes.*
This commit is contained in:
parent
a8d3d2773e
commit
9c7cb5d778
34 changed files with 502 additions and 248 deletions
|
|
@ -1,35 +1,32 @@
|
|||
using System;
|
||||
namespace Server.Items;
|
||||
|
||||
namespace Server.Items
|
||||
public class BookPageInfo
|
||||
{
|
||||
public class BookPageInfo
|
||||
public BookPageInfo() => Lines = [];
|
||||
|
||||
public BookPageInfo(params string[] lines) => Lines = lines;
|
||||
|
||||
public BookPageInfo(IGenericReader reader)
|
||||
{
|
||||
public BookPageInfo() => Lines = Array.Empty<string>();
|
||||
var length = reader.ReadInt();
|
||||
|
||||
public BookPageInfo(params string[] lines) => Lines = lines;
|
||||
Lines = new string[length];
|
||||
|
||||
public BookPageInfo(IGenericReader reader)
|
||||
for (var i = 0; i < Lines.Length; ++i)
|
||||
{
|
||||
var length = reader.ReadInt();
|
||||
|
||||
Lines = new string[length];
|
||||
|
||||
for (var i = 0; i < Lines.Length; ++i)
|
||||
{
|
||||
Lines[i] = reader.ReadString().Intern();
|
||||
}
|
||||
Lines[i] = reader.ReadString().Intern();
|
||||
}
|
||||
}
|
||||
|
||||
public string[] Lines { get; set; }
|
||||
public string[] Lines { get; set; }
|
||||
|
||||
public void Serialize(IGenericWriter writer)
|
||||
public void Serialize(IGenericWriter writer)
|
||||
{
|
||||
writer.Write(Lines.Length);
|
||||
|
||||
for (var i = 0; i < Lines.Length; ++i)
|
||||
{
|
||||
writer.Write(Lines.Length);
|
||||
|
||||
for (var i = 0; i < Lines.Length; ++i)
|
||||
{
|
||||
writer.Write(Lines[i]);
|
||||
}
|
||||
writer.Write(Lines[i]);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue