fix: Fixes dupe property copying. Adds IgnoreDupe (#1811)
## Summary ### Changes - Adds `[IgnoreDupe]` and `[SerializedIgnoreDupe]` - Updates all _known_ classes that need the attribute. Some might be missing, please helps us find them! - Adds `Item.Dupe()` command and encapsulates `CopyProperties` and `OnAfterDuped`. This is also overridable. - Updates Dupe command to use the new logic. - Fixes duping multiple kinds of objects that used to be outright broken. ### Bug Fixes - Fixes issue with durability after duping - Fixes issue with hue after duping > [!Note] > **Developer Note** > Customizing how duping an item works now requires two steps: > 1. Add `[IgnoreDupe]` or `[SerializedIgnoreDupe]` to the property/field > 2. Add custom logic in an `OnAfterDuped` override > > When do you need to do this? > *When the property being copied is not a primitive, and you need to manually deep-clone the contents of the property such as with Lists, Dictionaries, or sub classes.*
This commit is contained in:
parent
a8d3d2773e
commit
9c7cb5d778
34 changed files with 502 additions and 248 deletions
|
|
@ -99,9 +99,11 @@ public partial class DawnsMusicBox : Item, ISecurable
|
|||
MusicName.SelimsBar, MusicName.SerpentIsleCombat_U7, MusicName.ValoriaShips
|
||||
};
|
||||
|
||||
[SerializedIgnoreDupe]
|
||||
[SerializableField(0, setter: "private")]
|
||||
private List<MusicName> _tracks;
|
||||
|
||||
[SerializedIgnoreDupe]
|
||||
[SerializableField(1)]
|
||||
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
||||
private SecureLevel _level;
|
||||
|
|
|
|||
|
|
@ -18,6 +18,7 @@ public partial class RoseOfTrinsic : Item, ISecurable
|
|||
[SerializableField(1, setter: "private")]
|
||||
private DateTime _nextSpawnTime;
|
||||
|
||||
[SerializedIgnoreDupe]
|
||||
[SerializableField(2)]
|
||||
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
||||
private SecureLevel _level;
|
||||
|
|
@ -34,6 +35,16 @@ public partial class RoseOfTrinsic : Item, ISecurable
|
|||
|
||||
public override int LabelNumber => 1062913; // Rose of Trinsic
|
||||
|
||||
public override void OnAfterDuped(Item newItem)
|
||||
{
|
||||
if (newItem is not RoseOfTrinsic rose)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
rose.NextSpawnTime = NextSpawnTime;
|
||||
}
|
||||
|
||||
[SerializableProperty(0)]
|
||||
[CommandProperty(AccessLevel.GameMaster)]
|
||||
public int Petals
|
||||
|
|
|
|||
|
|
@ -10,6 +10,7 @@ namespace Server.Items;
|
|||
[SerializationGenerator(1)]
|
||||
public partial class TapestryOfSosaria : Item, ISecurable
|
||||
{
|
||||
[SerializedIgnoreDupe]
|
||||
[SerializableField(0)]
|
||||
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
||||
private SecureLevel _level;
|
||||
|
|
|
|||
|
|
@ -17,6 +17,7 @@ public partial class SoulStone : Item, ISecurable
|
|||
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
||||
private string _lastUserName;
|
||||
|
||||
[SerializedIgnoreDupe]
|
||||
[SerializableField(1)]
|
||||
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
||||
private SecureLevel _level;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue