fix(ci): run test projects on CI; remove brittle OPL attribute tests (#2513)
## Problem Three coupled issues, each hiding the next: 1. **CI passed despite failing tests, with no test logs.** ([example run](https://github.com/modernuo/ModernUO/actions/runs/28639143286/job/84931544255) — the `Test` step produced zero output and the job went green.) 2. **Two `EmitsLowerStatReqWhenPassed` tests** fail with `KeyNotFoundException: '1060435'`. 3. Once CI actually ran the tests, **~337 UOContent tests failed** with `FileNotFoundException: tiledata.mul was not found` — the test bootstrap force-loaded copyrighted client data that CI doesn't have. ## Root causes & fixes ### 1. CI ran zero tests (`fix(ci)`) The `Test` step ran `dotnet test --no-restore`, but the `Build` step only restores/builds `Application` — never the test projects. Without a restore, the test projects have no `project.assets.json`, so `Microsoft.NET.Test.Sdk`'s targets aren't imported, they aren't recognized as test projects, and `dotnet test` runs the `VSTest` target against **zero** projects → no output, **exit 0**. - Both jobs now run `dotnet test --logger trx --results-directory ./TestResults` (test projects restore and run) **plus a guard** that fails the job if no `.trx` is produced — a permanent backstop against silent zero-test passes. ### 2. Impossible OPL tests (`fix(ci)` + `test(opl)`) #2501 deliberately emits `LowerStatReq` (`1060435`) **inline in each item**, not in `GetProperties`. A follow-up "fix" dropped the `lowerStatReq:` argument to make the tests compile but left the assertions expecting `1060435`. - Removed the two impossible tests, then removed the **entire `Tests/PropertyList/` OPL attribute set** from #2501: these assert exact cliloc/value/order of OPL emission per item base — a one-time proof of the #2501 rewire, now a permanent tax on modding (any admin reorder/value change/added line reddens the build). The one non-trivial case (LowerStatReq) is what just broke, because the test was wrong. Inline emission stays covered by the `BaseArmor`/`BaseClothing` tests. ### 3. Tile-data-dependent tests crashed CI (`test(uocontent)`) UOContent.Tests' collection-fixture constructor force-loaded `tiledata.mul` unconditionally. On CI (no client files) it threw, and xUnit failed **every test in the collection** with the same error — mostly collateral (packet/scheduler/spawner tests that don't need tile data). - Mirror Server.Tests' graceful pattern: `TestServerInitializer` probes for `tiledata.mul` and only loads tile/multi data (and runs the tile-dependent configure steps) when present, exposing `TileDataLoaded` so the fixture no longer throws. - Add a shared `TileDataRequirement.SkipIfMissing()` guard and apply it to exactly the **31** pathfinding/multi/AI tests that genuinely need real tile data (`[SkippableFact]`/`[SkippableTheory]`). ## Verification (all local) | Scenario | Server.Tests | UOContent.Tests | |---|---|---| | **Client data absent (CI)** | 726 pass, 17 skip, **0 fail** | 469 pass, 32 skip, **0 fail** | | **Client data present (dev)** | 726 pass, 0 skip, **0 fail** | 501 pass, 0 skip, **0 fail** | - Full `dotnet test` exits **0**; TRX files produced; the no-test guard trips (exit 1) only when zero `.trx` are produced.
This commit is contained in:
parent
8c6eab5fca
commit
a706ef1449
29 changed files with 124 additions and 546 deletions
14
.github/workflows/build-test.yml
vendored
14
.github/workflows/build-test.yml
vendored
|
|
@ -52,7 +52,12 @@ jobs:
|
|||
- name: Migration Changes
|
||||
run: git diff --exit-code ./**/Migrations/*.v*.json
|
||||
- name: Test
|
||||
run: dotnet test --no-restore
|
||||
run: |
|
||||
dotnet test --logger trx --results-directory ./TestResults
|
||||
if [ -z "$(find ./TestResults -name '*.trx' 2>/dev/null)" ]; then
|
||||
echo "::error::No test result files were produced - no test projects ran. Failing to avoid masking failures."
|
||||
exit 1
|
||||
fi
|
||||
|
||||
build-linux:
|
||||
runs-on: ubuntu-latest
|
||||
|
|
@ -106,4 +111,9 @@ jobs:
|
|||
- name: Build
|
||||
run: dotnet run --project Projects/BuildTool -- --config Release --skip-prereqs
|
||||
- name: Test
|
||||
run: dotnet test --no-restore
|
||||
run: |
|
||||
dotnet test --logger trx --results-directory ./TestResults
|
||||
if [ -z "$(find ./TestResults -name '*.trx' 2>/dev/null)" ]; then
|
||||
echo "::error::No test result files were produced - no test projects ran. Failing to avoid masking failures."
|
||||
exit 1
|
||||
fi
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue