warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: Overhauls AI (Speech/Movement) (#2232)

Browse source 
### Summary

* Refactors AI so it is easier to read and maintain
* Fixes NPC speed issues
* Fixes pet sector AI issue that was causing stuttering
* Fixes direction snapping for Melee/Mage AI
* Refactors pet orders
* Refactors speech commands
* Removes scale speed by dex for HS+ (it was a stupid feature anyways)
This commit is contained in:
Kamron Batman 2025-07-18 22:39:57 -07:00 • committed by GitHub
parent f89150735e
commit aab731ed96
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
26 changed files with 3688 additions and 3429 deletions
Download patch file Download diff file Expand all files Collapse all files

190
Projects/UOContent/Mobiles/AI/BaseAI/TransferItem.cs Normal file
View file

@ -0,0 +1,190 @@
/*************************************************************************
* ModernUO *
* Copyright 2019-2025 - ModernUO Development Team *
* Email: hi@modernuo.com *
* File: TransferItem.cs *
* *
* This program is free software: you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation, either version 3 of the License, or *
* (at your option) any later version. *
* *
* You should have received a copy of the GNU General Public License *
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
************************************************************************/
using System;
using System.Runtime.CompilerServices;
namespace Server.Mobiles;
internal sealed class TransferItem : Item
{
private readonly BaseCreature _creature;
public override string DefaultName => _creature.GetType().Name;
public TransferItem(BaseCreature creature) : base(ShrinkTable.Lookup(creature))
{
_creature = creature;
Movable = false;
Hue = creature.Hue & 0x0FFF;
}
public TransferItem(Serial serial) : base(serial)
{
}
public static bool IsInCombat(BaseCreature creature) => creature?.Aggressors.Count > 0 || creature?.Aggressed.Count > 0;
public override void Serialize(IGenericWriter writer)
{
base.Serialize(writer);
writer.Write(0); // version
}
public override void Deserialize(IGenericReader reader)
{
base.Deserialize(reader);
reader.ReadInt(); // version
Delete();
}
public override void GetProperties(IPropertyList list)
{
base.GetProperties(list);
list.Add(1041603); // This item represents a pet currently in consideration for trade
list.Add(1041601, _creature.Name); // Pet Name: ~1_val~
if (_creature.ControlMaster != null)
{
list.Add(1041602, _creature.ControlMaster.Name); // Owner: ~1_val~
}
}
public override bool AllowSecureTrade(Mobile from, Mobile to, Mobile newOwner, bool accepted)
{
if (!base.AllowSecureTrade(from, to, newOwner, accepted) || IsInvalidTrade(from, to))
{
return false;
}
return !accepted || HandleAcceptedTrade(from, to);
}
private bool IsInvalidTrade(Mobile from, Mobile to) =>
Deleted
|| _creature?.Deleted != false
|| _creature.ControlMaster != from
|| !from.CheckAlive()
|| !to.CheckAlive()
|| from.Map != _creature.Map
|| !from.InRange(_creature, 14);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private bool HandleAcceptedTrade(Mobile from, Mobile to) =>
ValidateYoungStatus(from, to) && ValidateControlStatus(from, to) && ValidateFollowerLimit(to) &&
!IsInCombat(_creature);
private bool ValidateFollowerLimit(Mobile to)
{
if (to.Followers + _creature.ControlSlots > to.FollowersMax)
{
to.SendLocalizedMessage(1049607);
// You have too many followers to control that creature.
return false;
}
return true;
}
private static bool ValidateYoungStatus(Mobile from, Mobile to)
{
var youngFrom = from is PlayerMobile mobile && mobile.Young;
var youngTo = to is PlayerMobile playerMobile && playerMobile.Young;
if (youngFrom && !youngTo)
{
from.SendLocalizedMessage(502051);
// As a young player, you may not transfer pets to older players.
return false;
}
if (!youngFrom && youngTo)
{
from.SendLocalizedMessage(502052);
// As an older player, you may not transfer pets to young players.
return false;
}
return true;
}
private bool ValidateControlStatus(Mobile from, Mobile to)
{
if (!_creature.CanBeControlledBy(to))
{
SendTransferRefusalMessages(from, to, 1043248, 1043249);
// The pet refuses to be transferred because it will not obey ~1_NAME~.~3_BLANK~
// The pet will not accept you as a master because it does not trust you.~3_BLANK~
return false;
}
if (!_creature.CanBeControlledBy(from))
{
SendTransferRefusalMessages(from, to, 1043250, 1043251);
// The pet refuses to be transferred because it will not obey you sufficiently.~3_BLANK~
// The pet will not accept you as a master because it does not trust ~2_NAME~.~3_BLANK~
return false;
}
return true;
}
private static void SendTransferRefusalMessages(Mobile from, Mobile to, int fromMessage, int toMessage)
{
var args = $"{to.Name}\t{from.Name}\t ";
from.SendLocalizedMessage(fromMessage, args);
to.SendLocalizedMessage(toMessage, args);
}
public override void OnSecureTrade(Mobile from, Mobile to, Mobile newOwner, bool accepted)
{
if (Deleted || IsInvalidTrade(from, to))
{
Delete();
return;
}
Delete();
if (!accepted || !_creature.SetControlMaster(to))
{
return;
}
TransferPetOwnership(from, to);
}
private void TransferPetOwnership(Mobile from, Mobile to)
{
if (_creature.Summoned)
{
_creature.SummonMaster = to;
}
_creature.ControlTarget = to;
_creature.ControlOrder = OrderType.Follow;
_creature.BondingBegin = DateTime.MinValue;
_creature.OwnerAbandonTime = DateTime.MinValue;
_creature.IsBonded = false;
_creature.PlaySound(_creature.GetIdleSound());
var args = $"{from.Name}\t{_creature.Name}\t{to.Name}";
from.SendLocalizedMessage(1043253, args);
// You have transferred your pet to ~3_GETTER~.
to.SendLocalizedMessage(1043252, args);
// ~1_NAME~ has transferred the allegiance of ~2_PET_NAME~ to you.
}
}