fix: Adds BitArray support with codegen (#888)

* Adds a custom BitArray class with the following added features:
  * ctor for creating BitArray against read only span
  * ctor for creating BitArray against BinaryReader
  * CopyTo to copy a BitArray to a Span
* Adds BitArray to UO Primitive serialization so it can be codegenned.

Projects/Server/Serialization/BinaryFileReader.cs

@@ -16,6 +16,7 @@
 using System;
 using System.IO;
 using System.Runtime.CompilerServices;
+using Server.Collections;
 
 namespace Server
 {
@@ -78,6 +79,15 @@ namespace Server
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public int Read(Span<byte> buffer) => _reader.Read(buffer);
 
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        public BitArray ReadBitArray()
+        {
+            var length = ((IGenericReader)this).ReadEncodedInt();
+
+            // BinaryReader doesn't expose a Span slice of the buffer, so we use a custom ctor
+            return new BitArray(_reader, length);
+        }
+
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public long Seek(long offset, SeekOrigin origin) => _reader.BaseStream.Seek(offset, origin);
 

Projects/Server/Serialization/BufferReader.cs

@@ -19,6 +19,7 @@ using System.Diagnostics;
 using System.IO;
 using System.Runtime.CompilerServices;
 using System.Text;
+using Server.Collections;
 using Server.Text;
 
 namespace Server
@@ -156,6 +157,19 @@ namespace Server
             return length;
         }
 
+        public BitArray ReadBitArray()
+        {
+            var length = ((IGenericReader)this).ReadEncodedInt();
+            if (length > _buffer.Length - _position)
+            {
+                throw new OutOfMemoryException();
+            }
+
+            var bitArray = new BitArray(_buffer.AsSpan(_position, length));
+            _position += length;
+            return bitArray;
+        }
+
         public virtual long Seek(long offset, SeekOrigin origin)
         {
             Debug.Assert(

Projects/Server/Serialization/BufferWriter.cs

@@ -18,6 +18,7 @@ using System.Diagnostics;
 using System.IO;
 using System.Runtime.CompilerServices;
 using System.Text;
+using Server.Collections;
 using Server.Text;
 
 namespace Server
@@ -134,6 +135,16 @@ namespace Server
             }
         }
 
+        public void Write(BitArray bitArray)
+        {
+            var byteLength = BitArray.GetByteArrayLengthFromBitLength(bitArray.Length);
+            FlushIfNeeded(byteLength + 4);
+
+            ((IGenericWriter)this).WriteEncodedInt(byteLength);
+            bitArray.CopyTo(_buffer.AsSpan((int)Index, byteLength));
+            Index += byteLength;
+        }
+
         public virtual long Seek(long offset, SeekOrigin origin)
         {
             Debug.Assert(

Projects/Server/Serialization/IGenericReader.cs

@@ -16,6 +16,7 @@
 using System;
 using System.IO;
 using System.Net;
+using Server.Collections;
 
 namespace Server
 {
@@ -116,6 +117,8 @@ namespace Server
             return new Guid(bytes);
         }
 
+        BitArray ReadBitArray();
+
         long Seek(long offset, SeekOrigin origin);
     }
 }

Projects/Server/Serialization/IGenericWriter.cs

@@ -16,6 +16,7 @@
 using System;
 using System.IO;
 using System.Net;
+using Server.Collections;
 
 namespace Server
 {
@@ -160,6 +161,8 @@ namespace Server
             Write(stack);
         }
 
+        void Write(BitArray bitArray);
+
         long Seek(long offset, SeekOrigin origin);
     }
 }