warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf(messages): mechanical interpolation cleanups (#2436)

Browse source 
## Summary

Phase 3.1 of the message-interpolation optimization series. Fixes 9 of the 28 sites flagged in the Phase 2 audit (PR #2435):

| File | Fix |
|---|---|
| `Commands/StaffAccess.cs:88,99` | Drop redundant `.ToString()` on enum holes |
| `Commands/Handlers.cs:102` | `builder.ToString()` -> `builder.AsSpan()` |
| `World Saves/SaveCommands.cs:71-75` | Merge 3 concatenated `$"..."` into one literal |
| `Server/Items/Item.cs:4213` | Hoist nested ternary `$"..."` to if/else |
| `Engines/Factions/Mobiles/Guards/BaseFactionGuard.cs:140-150` | Convert switch expression to switch statement |
| `Mobiles/Monsters/LBR/Jukas/JukaLord.cs:85` | Restructure `string.Format(toSay.RandomElement(), ...)` into switch |
| `Misc/AttackMessage.cs:30-41` | Inline `AggressorFormat`/`AggressedFormat` constants |

No functional changes. Each site emits identical text; the only difference is that the message string is now built into a pooled char buffer instead of being allocated as a `string` first.
This commit is contained in:
Kamron Batman 2026-05-03 18:26:49 -07:00 • committed by GitHub
parent 679e66b99d
commit b2ccc7e4f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 53 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Projects/UOContent/Misc/AttackMessage.cs
View file

@ -4,8 +4,6 @@ namespace Server.Misc
{
public static class AttackMessage
{
private const string AggressorFormat = "You are attacking {0}!";
private const string AggressedFormat = "{0} is attacking you!";
private const int Hue = 0x22;
private static readonly TimeSpan Delay = TimeSpan.FromMinutes(1.0);
@ -31,13 +29,13 @@ namespace Server.Misc
MessageType.Regular,
Hue,
true,
string.Format(AggressorFormat, aggressed.Name)
$"You are attacking {aggressed.Name}!"
);
aggressed.LocalOverheadMessage(
MessageType.Regular,
Hue,
true,
string.Format(AggressedFormat, aggressor.Name)
$"{aggressor.Name} is attacking you!"
);
}
}