fix: Fixes localization corner cases with OPL (#1050)
## Changes
- [X] Adds OPL convenience methods
- `opl.Add(cliloc, value)` and `opl.Add(value)` - value as an integer or string works just like `opl.Add(cliloc, $"{value}")`
- `opl.AddLocalized(cliloc, clilocValue)` - works the same as `opl.Add(cliloc, $"#{clilocValue}");`
- [X] Simplifies basic `list.Add()` situations
- [X] Changes cliloc as an argument so it works with custom IPropertyList implementations (HTML)
- [X] Fixes plants so they support the old localization and new (changed in 7.0.12.0+)
- [X] Exposes more methods to override for Item to make creating custom OPL possible.
## Important Notes
* Using a ternary as an argument, like this `opl.Add(number, showType ? $"{type}\t{value}" : $"{value}");` _will not use the correct string interpolation_. This means if you use a custom PropertyList (for HTML or some other purpose), the property list won't be localized properly.
* All localization values must be interpolated, even if they are literal strings, or integers. Example: `opl.Add(number, $"{"Charges"}\t{m_Charges}");` is correct. Using the following: `$"Charges\t{m_Charges}"` will not work for custom PropertyList implementations!
This commit is contained in:
parent
12404ba6f6
commit
b74b47159f
75 changed files with 715 additions and 477 deletions
|
|
@ -3413,9 +3413,9 @@ namespace Server
|
|||
|
||||
public int GetAOSStatus(int index) => AOSStatusHandler?.Invoke(this, index) ?? 0;
|
||||
|
||||
public virtual void SendPropertiesTo(Mobile from)
|
||||
public virtual void SendPropertiesTo(NetState ns)
|
||||
{
|
||||
from.NetState?.Send(PropertyList.Buffer);
|
||||
ns?.Send(PropertyList.Buffer);
|
||||
}
|
||||
|
||||
public virtual void OnAosSingleClick(Mobile from)
|
||||
|
|
@ -3485,11 +3485,14 @@ namespace Server
|
|||
|
||||
if (guildTitle.Length > 0)
|
||||
{
|
||||
list.Add(
|
||||
NewGuildDisplay
|
||||
? $"{Utility.FixHtml(guildTitle)}, {Utility.FixHtml(guild.Name)}"
|
||||
: $"{Utility.FixHtml(guildTitle)}, {Utility.FixHtml(guild.Name)} Guild{type}"
|
||||
);
|
||||
if (NewGuildDisplay)
|
||||
{
|
||||
list.Add($"{Utility.FixHtml(guildTitle)}, {Utility.FixHtml(guild.Name)}");
|
||||
}
|
||||
else
|
||||
{
|
||||
list.Add($"{Utility.FixHtml(guildTitle)}, {Utility.FixHtml(guild.Name)} Guild{type}");
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue