fix: Fixes double calls with Target cancel and spell sequences (#1840)

### Summary
- Cleans up target cancellation being called incorrectly.
- An invalid target type (which should never happen), now calls `OnTargetUntargetable` instead of `OnTargetCanceled`
- Removes double calls to `FinishSequence` in Spells.
This commit is contained in:
Kamron Batman 2024-06-17 15:19:06 -07:00 • committed by GitHub
parent 9c0b57213a
commit b8ad5c671d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
80 changed files with 201 additions and 406 deletions

View file

@ -98,8 +98,6 @@ namespace Server.Spells.Chivalry
AOS.Damage(Caster, Caster, damage, 0, 100, 0, 0, 0, true);
}
FinishSequence();
}
public override bool CheckCast()

View file

@ -78,8 +78,6 @@ namespace Server.Spells.Chivalry
m.FixedParticles(0x376A, 1, 62, 9923, 3, 3, EffectLayer.Waist);
m.FixedParticles(0x3779, 1, 46, 9502, 5, 3, EffectLayer.Waist);
}
FinishSequence();
}
public override bool CheckCast()

View file

@ -124,8 +124,6 @@ namespace Server.Spells.Chivalry
m.PlaySound(0x1DF);
}
}
FinishSequence();
}
public override bool CheckCast()

View file

@ -109,8 +109,6 @@ namespace Server.Spells.Chivalry
Caster.MoveToWorld(loc, map);
Caster.PlaySound(0x1FC);
}
FinishSequence();
}
public override void OnCast()
@ -122,6 +120,7 @@ namespace Server.Spells.Chivalry
else
{
Effect(m_Entry.Location, m_Entry.Map, true);
FinishSequence();
}
}