warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes double calls with Target cancel and spell sequences (#1840)

Browse source 
### Summary
- Cleans up target cancellation being called incorrectly.
- An invalid target type (which should never happen), now calls `OnTargetUntargetable` instead of `OnTargetCanceled`
- Removes double calls to `FinishSequence` in Spells.
This commit is contained in:
Kamron Batman 2024-06-17 15:19:06 -07:00 • committed by GitHub
parent 9c0b57213a
commit b8ad5c671d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
80 changed files with 201 additions and 406 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Projects/UOContent/Spells/Second/Agility.cs
View file

@ -36,8 +36,6 @@ namespace Server.Spells.Second
BuffInfo.AddBuff(m, new BuffInfo(BuffIcon.Agility, 1075841, length, m, percentage.ToString()));
}
FinishSequence();
}
public override bool CheckCast()

2
Projects/UOContent/Spells/Second/Cunning.cs
View file

@ -36,8 +36,6 @@ namespace Server.Spells.Second
BuffInfo.AddBuff(m, new BuffInfo(BuffIcon.Cunning, 1075843, length, m, percentage.ToString()));
}
FinishSequence();
}
public override bool CheckCast()

2
Projects/UOContent/Spells/Second/Cure.cs
View file

@ -55,8 +55,6 @@ namespace Server.Spells.Second
m.FixedParticles(0x373A, 10, 15, 5012, EffectLayer.Waist);
m.PlaySound(0x1E0);
}
FinishSequence();
}
public override bool CheckCast()

2
Projects/UOContent/Spells/Second/Harm.cs
View file

@ -71,8 +71,6 @@ namespace Server.Spells.Second
SpellHelper.Damage(this, m, damage, 0, 0, 100, 0, 0);
}
FinishSequence();
}
public override void OnCast()

2
Projects/UOContent/Spells/Second/MagicTrap.cs
View file

@ -78,8 +78,6 @@ namespace Server.Spells.Second
Effects.PlaySound(loc, item.Map, 0x1EF);
}
FinishSequence();
}
public override void OnCast()

2
Projects/UOContent/Spells/Second/RemoveTrap.cs
View file

@ -48,8 +48,6 @@ namespace Server.Spells.Second
cont.TrapPower = 0;
cont.TrapLevel = 0;
}
FinishSequence();
}
public override void OnCast()

2
Projects/UOContent/Spells/Second/Strength.cs
View file

@ -36,8 +36,6 @@ namespace Server.Spells.Second
BuffInfo.AddBuff(m, new BuffInfo(BuffIcon.Strength, 1075845, length, m, percentage.ToString()));
}
FinishSequence();
}
public override bool CheckCast()