fix: Fixes double calls with Target cancel and spell sequences (#1840)

### Summary
- Cleans up target cancellation being called incorrectly.
- An invalid target type (which should never happen), now calls `OnTargetUntargetable` instead of `OnTargetCanceled`
- Removes double calls to `FinishSequence` in Spells.
This commit is contained in:
Kamron Batman 2024-06-17 15:19:06 -07:00 • committed by GitHub
parent 9c0b57213a
commit b8ad5c671d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
80 changed files with 201 additions and 406 deletions

View file

@ -95,8 +95,6 @@ namespace Server.Spells.Seventh
}
}
}
FinishSequence();
}
public override void OnCast()

View file

@ -67,8 +67,6 @@ public class EnergyFieldSpell : MagerySpell, ISpellTargetingPoint3D
);
}
}
FinishSequence();
}
public override void OnCast()

View file

@ -54,8 +54,6 @@ namespace Server.Spells.Seventh
SpellHelper.Damage(this, m, damage, 0, 100, 0, 0, 0);
}
FinishSequence();
}
public override void OnCast()

View file

@ -94,8 +94,6 @@ public class GateTravelSpell : MagerySpell, IRecallSpell
firstGate.LinkedGate = secondGate;
secondGate.LinkedGate = firstGate;
}
FinishSequence();
}
public override void OnCast()
@ -107,6 +105,7 @@ public class GateTravelSpell : MagerySpell, IRecallSpell
else
{
Effect(m_Entry.Location, m_Entry.Map, true);
FinishSequence();
}
}

View file

@ -75,8 +75,6 @@ namespace Server.Spells.Seventh
HarmfulSpell(m);
}
FinishSequence();
}
public override void OnCast()

View file

@ -72,8 +72,6 @@ namespace Server.Spells.Seventh
}
}
}
FinishSequence();
}
public override void OnCast()

View file

@ -100,8 +100,6 @@ namespace Server.Spells.Seventh
}
}
}
FinishSequence();
}
public override void OnCast()