fix: Fixes double calls with Target cancel and spell sequences (#1840)

### Summary
- Cleans up target cancellation being called incorrectly.
- An invalid target type (which should never happen), now calls `OnTargetUntargetable` instead of `OnTargetCanceled`
- Removes double calls to `FinishSequence` in Spells.
This commit is contained in:
Kamron Batman 2024-06-17 15:19:06 -07:00 • committed by GitHub
parent 9c0b57213a
commit b8ad5c671d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
80 changed files with 201 additions and 406 deletions

View file

@ -54,8 +54,6 @@ namespace Server.Spells.Sixth
Caster.SendLocalizedMessage(1010084); // The creature resisted the attempt to dispel it!
}
}
FinishSequence();
}
public override void OnCast()

View file

@ -59,8 +59,6 @@ namespace Server.Spells.Sixth
// Deal the damage
SpellHelper.Damage(this, m, damage, 0, 0, 0, 0, 100);
}
FinishSequence();
}
public override void OnCast()

View file

@ -39,10 +39,8 @@ namespace Server.Spells.Sixth
SpellHelper.Turn(Caster, m);
SpellHelper.CheckReflect((int)Circle, Caster, ref m);
var t = new InternalTimer(this, Caster, defender, m).Start();
new InternalTimer(this, Caster, defender, m).Start();
}
FinishSequence();
}
public override void OnCast()

View file

@ -67,8 +67,6 @@ namespace Server.Spells.Sixth
_table[m] = timerToken;
}
FinishSequence();
}
public override bool CheckCast()

View file

@ -55,8 +55,6 @@ namespace Server.Spells.Sixth
Caster.PlaySound(0x1FA);
Effects.SendLocationEffect(Caster, 14201, 16);
}
FinishSequence();
}
public override void OnCast()

View file

@ -54,8 +54,6 @@ namespace Server.Spells.Sixth
}
}
}
FinishSequence();
}
public override void OnCast()

View file

@ -67,8 +67,6 @@ public class ParalyzeFieldSpell : MagerySpell, ISpellTargetingPoint3D
);
}
}
FinishSequence();
}
public override void OnCast()

View file

@ -51,8 +51,6 @@ namespace Server.Spells.Sixth
}
}
}
FinishSequence();
}
public override void OnCast()