warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes ObjectPropertyList double return issue (#1969)

Browse source 
- Fixes double return issue with object property list that is causing corruption.
- Adds DEBUG_ARRAYPOOL define constant which will crash on double return or invalid return scenarios.

> [!IMPORTANT]
> **Developer Notes**
> STArrayPool rented arrays **MUST NOT** be returned **ONLY ONCE** otherwise there will be corruption from double-use.
> Use `DEBUG_ARRAYPOOL` to test potential broken STArrayPool use cases.

> [!NOTE]
> **Why can't I enable the debug all the time?**
> Other than the fact that it will crash due to bad code, the actual tracking system is highly detrimental/problematic for performance and memory consumption by creating objects that have a stack trace.
This commit is contained in:
Kamron Batman 2024-10-07 19:21:55 -07:00
parent 4b3b2839c6
commit b9d63e4160
No known key found for this signature in database
GPG key ID: 7D81DF26D9A5D94A
3 changed files with 69 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Projects/Server/PropertyList/ObjectPropertyList.cs
View file

@ -1,6 +1,6 @@
/*************************************************************************
* ModernUO *
* Copyright 2019-2023 - ModernUO Development Team *
* Copyright 2019-2024 - ModernUO Development Team *
* Email: hi@modernuo.com *
* File: ObjectPropertyList.cs *
* *
@ -79,8 +79,9 @@ public sealed class ObjectPropertyList : IPropertyList, IDisposable
_stringNumbersIndex = 0;
Header = 0;
HeaderArgs = null;
STArrayPool<char>.Shared.Return(_arrayToReturnToPool);
_pos = 0;
Dispose();
}
private void Flush()
@ -499,13 +500,19 @@ public sealed class ObjectPropertyList : IPropertyList, IDisposable
public void Dispose()
{
STArrayPool<char>.Shared.Return(_arrayToReturnToPool);
_arrayToReturnToPool = null;
if (_arrayToReturnToPool != null)
{
STArrayPool<char>.Shared.Return(_arrayToReturnToPool);
_arrayToReturnToPool = null;
}
}
~ObjectPropertyList()
{
STArrayPool<char>.Shared.Return(_arrayToReturnToPool);
_arrayToReturnToPool = null;
if (_arrayToReturnToPool != null)
{
STArrayPool<char>.Shared.Return(_arrayToReturnToPool);
_arrayToReturnToPool = null;
}
}
}