From c266294e31e0a3e1e279e00e669b6a986fb0ad30 Mon Sep 17 00:00:00 2001 From: Kamron Batman <3953314+kamronbatman@users.noreply.github.com> Date: Sat, 17 Dec 2022 17:06:12 -0800 Subject: [PATCH] fix: Fixes Point3D.Parse (#1305) --- Projects/Server.Tests/Tests/Geometry/Point3DTests.cs | 2 ++ Projects/Server/Geometry/Point3D.cs | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Projects/Server.Tests/Tests/Geometry/Point3DTests.cs b/Projects/Server.Tests/Tests/Geometry/Point3DTests.cs index c2ddef41e..e90a7531d 100644 --- a/Projects/Server.Tests/Tests/Geometry/Point3DTests.cs +++ b/Projects/Server.Tests/Tests/Geometry/Point3DTests.cs @@ -12,6 +12,8 @@ public class Point3DTests var successful = Point3D.TryParse(text, null, out var p); Assert.True(successful); Assert.Equal(new Point3D(x, y, z), p); + + Assert.Equal(new Point3D(x, y, z), Point3D.Parse(text, null)); } [Fact] diff --git a/Projects/Server/Geometry/Point3D.cs b/Projects/Server/Geometry/Point3D.cs index e1e1b0674..840257223 100644 --- a/Projects/Server/Geometry/Point3D.cs +++ b/Projects/Server/Geometry/Point3D.cs @@ -198,7 +198,7 @@ public struct Point3D var offset = firstComma + 1; var secondComma = s[offset..].IndexOfOrdinal(','); - if (secondComma == -1 || offset == secondComma) + if (secondComma == -1) { throw new FormatException($"The input string '{s}' was not in a correct format."); }