Revert "Updates Packets & Randomizer (#43)" (#61)

This reverts commit 179cb50557.

Projects/Scripts/Engines/MLQuests/Mobiles/BoonCollector.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using Server.Engines.MLQuests.Definitions;
 using Server.Engines.MLQuests.Gumps;
 using Server.Items;
@@ -136,7 +135,20 @@ namespace Server.Engines.MLQuests.Mobiles
     {
       MLQuestContext context = MLQuestSystem.GetContext(pm);
 
-      return context == null ? 0 : Needed.Select(MLQuestSystem.FindQuest).Count(quest => quest == null || context.HasDoneQuest(quest));
+      if (context == null)
+        return 0;
+
+      int result = 0;
+
+      foreach (Type type in Needed)
+      {
+        MLQuest quest = MLQuestSystem.FindQuest(type);
+
+        if (quest == null || context.HasDoneQuest(quest))
+          ++result;
+      }
+
+      return result;
     }
 
     public virtual void OnComplete(PlayerMobile pm)

Projects/Scripts/Engines/MLQuests/Mobiles/SirHelper.cs

@@ -42,7 +42,9 @@ namespace Server.Engines.MLQuests.Mobiles
 
     public override bool GetGender() => false;
 
-    public override bool CheckMorph() => true;
+    public override void CheckMorph()
+    {
+    }
 
     public override void InitOutfit()
     {
@@ -51,9 +53,22 @@ namespace Server.Engines.MLQuests.Mobiles
       HairHue = FacialHairHue = 0x8A7;
 
       AddItem(new Sandals());
-      AddItem(new Cloak{ ItemID = 0x26AD, Hue = 0x455});
-      AddItem(new Robe {ItemID = 0x26AE, Hue = 0x4AB});
-      AddItem(new Backpack {Movable = false});
+
+      Item item;
+
+      item = new Cloak();
+      item.ItemID = 0x26AD;
+      item.Hue = 0x455;
+      AddItem(item);
+
+      item = new Robe();
+      item.ItemID = 0x26AE;
+      item.Hue = 0x4AB;
+      AddItem(item);
+
+      item = new Backpack();
+      item.Movable = false;
+      AddItem(item);
     }
 
     public override void OnDoubleClick(Mobile from)
@@ -77,23 +92,32 @@ namespace Server.Engines.MLQuests.Mobiles
 
       if (m_NextShout <= DateTime.UtcNow)
       {
-        IPooledEnumerable eable = GetClientsInRange(12);
-        foreach (NetState state in eable)
+        Packet shoutPacket = null;
+
+        foreach (NetState state in GetClientsInRange(12))
         {
           Mobile m = state.Mobile;
 
           if (m.CanSee(this) && m.InLOS(this) && m.CanBeginAction(this))
-            Packets.SendMessageLocalized(state, Serial, Body, MessageType.Regular, 946, 3,
-              1078099, Name); // Double Click On Me For Help!
+          {
+            if (shoutPacket == null)
+              shoutPacket = Packet.Acquire(new MessageLocalized(Serial, Body, MessageType.Regular, 946, 3,
+                1078099, Name, "")); // Double Click On Me For Help!
+
+            state.Send(shoutPacket);
+          }
         }
 
-        eable.Free();
+        Packet.Release(shoutPacket);
 
         m_NextShout = DateTime.UtcNow + m_ShoutDelay;
       }
     }
 
-    private void EndLock(Mobile m) => m.EndAction(this);
+    private void EndLock(Mobile m)
+    {
+      m.EndAction(this);
+    }
 
     public override void Serialize(GenericWriter writer)
     {
@@ -111,4 +135,4 @@ namespace Server.Engines.MLQuests.Mobiles
       Frozen = true;
     }
   }
-}
+}