warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(codegen): Fixes bool in migration structs (#709)

Browse source 
* Fixes bool? not being a valid type for save flag property migrations.
* Fixes wrong SaveFlag type used in the if check for boolean save flags.
This commit is contained in:
Kamron Batman 2021-08-20 22:46:13 -07:00 • committed by GitHub
parent 1d916fe2df
commit c2f28f9a98
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Projects/SerializationGenerator/SerializableEntityGeneration/SerializationEntityGeneration.ContentStruct.cs
View file

@ -38,9 +38,10 @@ namespace SerializationGenerator
foreach (var serializableProperty in properties) foreach (var serializableProperty in properties)
{ {
var type = compilation.GetTypeByMetadataName(serializableProperty.Type)?.IsValueType == true var propertyType = serializableProperty.Type;
|| SymbolMetadata.IsPrimitiveFromTypeDisplayString(serializableProperty.Type) var type = compilation.GetTypeByMetadataName(propertyType)?.IsValueType == true
? $"{serializableProperty.Type}?" : serializableProperty.Type; || SymbolMetadata.IsPrimitiveFromTypeDisplayString(propertyType) && propertyType != "bool"
? $"{propertyType}?" : propertyType;
source.AppendLine($"{indent} internal readonly {type} {serializableProperty.Name};"); source.AppendLine($"{indent} internal readonly {type} {serializableProperty.Name};");
} }
@ -90,7 +91,7 @@ namespace SerializationGenerator
// Special case // Special case
if (property.Type == "bool") if (property.Type == "bool")
{ {
source.AppendLine($"{innerIndent}{property.Name} = (saveFlags & SaveFlag.{property.Name}) != 0;"); source.AppendLine($"{innerIndent}{property.Name} = (saveFlags & V{migration.Version}SaveFlag.{property.Name}) != 0;");
} }
else else
{ {