warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes container enumeration not recycling pooled arrays (#2341)

Browse source 
### Summary

Updates all calls to container.EnumerateItems() to properly dispose of the underlying PooledRefQueue so that we are properly recycling pooled arrays.
This commit is contained in:
Kamron Batman 2026-02-17 09:54:32 -08:00 • committed by GitHub
parent 1780edf0be
commit c494fb4cc3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
15 changed files with 388 additions and 365 deletions
Download patch file Download diff file Expand all files Collapse all files

37
Projects/UOContent/Items/Containers/SalvageBag.cs
View file

@ -201,7 +201,8 @@ public partial class SalvageBag : Bag
var salvaged = 0;
var notSalvaged = 0;
foreach (var item in EnumerateItems())
using var queue = EnumerateItems();
foreach (var item in queue)
{
if (item?.Deleted != false)
{
@ -250,31 +251,37 @@ public partial class SalvageBag : Bag
var salvaged = 0;
var notSalvaged = 0;
foreach (var item in EnumerateItems())
using (var queue = EnumerateItems())
{
if (item is not IScissorable scissorable)
foreach (var item in queue)
{
continue;
}
if (item is not IScissorable scissorable)
{
continue;
}
if (Scissors.CanScissor(from, scissorable) && scissorable.Scissor(from, scissors))
{
++salvaged;
}
else
{
++notSalvaged;
if (Scissors.CanScissor(from, scissorable) && scissorable.Scissor(from, scissors))
{
++salvaged;
}
else
{
++notSalvaged;
}
}
}
// Salvaged: ~1_COUNT~/~2_NUM~ tailored items
from.SendLocalizedMessage(1079974, $"{salvaged}\t{salvaged + notSalvaged}");
foreach (var item in EnumerateItems())
using (var queue = EnumerateItems())
{
if (item.InTypeList(_clothTypes))
foreach (var item in queue)
{
from.AddToBackpack(item);
if (item.InTypeList(_clothTypes))
{
from.AddToBackpack(item);
}
}
}
}