warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes container enumeration not recycling pooled arrays (#2341)

Browse source 
### Summary

Updates all calls to container.EnumerateItems() to properly dispose of the underlying PooledRefQueue so that we are properly recycling pooled arrays.
This commit is contained in:
Kamron Batman 2026-02-17 09:54:32 -08:00 • committed by GitHub
parent 1780edf0be
commit c494fb4cc3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
15 changed files with 388 additions and 365 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Projects/UOContent/Multis/Houses/MovingCrate.cs
View file

@ -1,5 +1,4 @@
using System;
using System.Collections.Generic;
using ModernUO.Serialization;
using Server.Items;
using Server.Network;
@ -195,18 +194,10 @@ public partial class MovingCrate : Container
_internalizeTimer = null;
}
var toRemove = new List<Item>();
foreach (var item in Items)
using var queue = EnumerateItems(predicate: item => item is PackingBox && item.Items.Count == 0);
while (queue.Count > 0)
{
if (item is PackingBox && item.Items.Count == 0)
{
toRemove.Add(item);
}
}
foreach (var item in toRemove)
{
item.Delete();
queue.Dequeue().Delete();
}
if (TotalItems == 0)