fix: Optimizes gump relay info (Prep for Static Gumps) (#1698)

This commit is contained in:
Kamron Batman 2024-03-07 20:54:53 -08:00 • committed by GitHub
parent 50fcee12dc
commit cfe9e04c78
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
220 changed files with 364 additions and 402 deletions

View file

@ -163,7 +163,7 @@ namespace Server.Items
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Box.Deleted || info.ButtonID == 0)
{

View file

@ -82,7 +82,7 @@ namespace Server.Items
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Aquarium?.Deleted != false)
{

View file

@ -477,7 +477,7 @@ public partial class TreasureMapChest : LockableContainer
AddHtmlLocalized(75, 197, 180, 35, 1006045, 0xFFFFFF); // Cancel
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (info.ButtonID == 1)
{

View file

@ -119,7 +119,7 @@ public partial class HairRestylingDeed : Item
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_From?.Alive != true)
{

View file

@ -130,7 +130,7 @@ public class HolidayTreeChoiceGump : Gump
AddHtmlLocalized(55, 65, 145, 25, 1018321); // Modern
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Deed.Deleted)
{

View file

@ -73,7 +73,7 @@ public class NameChangeDeedGump : Gump
AddHtml(x + 35, y, 240, 20, Color(text, 0xFFFFFF));
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Sender?.Deleted != false || info.ButtonID != 1 || m_Sender.RootParent != sender.Mobile)
{
@ -81,9 +81,8 @@ public class NameChangeDeedGump : Gump
}
var m = sender.Mobile;
var nameEntry = info.GetTextEntry(0);
var newName = nameEntry?.Text.Trim();
var newName = info.GetTextEntry(0)?.Trim();
if (!NameVerification.Validate(newName, 2, 16, true, false, true, 1, NameVerification.SpaceDashPeriodQuote))
{

View file

@ -122,7 +122,7 @@ public partial class NewPlayerTicket : Item
AddHtmlLocalized(154, 342, 100, 35, 1011012); // CANCEL
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Ticket.Deleted)
{

View file

@ -81,7 +81,7 @@ public class HairDyeGump : Gump
}
}
public override void OnResponse(NetState from, RelayInfo info)
public override void OnResponse(NetState from, in RelayInfo info)
{
if (_hairDye.Deleted)
{

View file

@ -98,7 +98,7 @@ public partial class InteriorDecorator : Item
AddHtmlLocalized(90, 150, 70, 40, 1018325); // Down
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
var command = info.ButtonID switch
{

View file

@ -346,7 +346,7 @@ public class PlayerBBGump : Gump
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
var page = _page;
var from = _from;

View file

@ -388,7 +388,7 @@ public partial class ControlPanel : AddonComponent
AddImage(x, y, id);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Panel.Deleted || info.ButtonID == 0 || !m_From.CheckAlive())
{

View file

@ -86,7 +86,7 @@ public abstract partial class PromotionalToken : Item
AddButton(90, 95, 0xF2, 0xF1, 0); // Cancel
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (info.ButtonID != 1)
{

View file

@ -432,7 +432,7 @@ public class MoongateGump : Gump
}
}
public override void OnResponse(NetState state, RelayInfo info)
public override void OnResponse(NetState state, in RelayInfo info)
{
if (info.ButtonID == 0) // Cancel
{

View file

@ -78,7 +78,7 @@ public class SpecialBeardDyeGump : Gump
}
}
public override void OnResponse(NetState from, RelayInfo info)
public override void OnResponse(NetState from, in RelayInfo info)
{
if (_specialBeardDye.Deleted)
{

View file

@ -78,7 +78,7 @@ public class SpecialHairDyeGump : Gump
}
}
public override void OnResponse(NetState from, RelayInfo info)
public override void OnResponse(NetState from, in RelayInfo info)
{
if (_specialHairDye.Deleted)
{

View file

@ -76,7 +76,7 @@ public abstract partial class BaseWindChimes : Item
AddHtmlLocalized(190, 55, 100, 35, 1011012); // CANCEL
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
var from = sender.Mobile;

View file

@ -88,7 +88,7 @@ public partial class Bedroll : Item
AddHtmlLocalized(235, 300, 110, 35, 1011012); // CANCEL
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
var pm = _entry.Player;

View file

@ -387,7 +387,7 @@ public class MoongateConfirmGump : Gump
}
}
public override void OnResponse(NetState state, RelayInfo info)
public override void OnResponse(NetState state, in RelayInfo info)
{
if (info.ButtonID == 1)
{

View file

@ -192,7 +192,7 @@ namespace Server.Items
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
switch (info.ButtonID)
{

View file

@ -56,7 +56,7 @@ namespace Server.Items
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
switch (info.ButtonID)
{

View file

@ -172,7 +172,7 @@ public class DisguiseGump : Gump
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (info.ButtonID == 0)
{

View file

@ -66,7 +66,7 @@ public class DawnsMusicBoxGump : Gump
AddHtmlLocalized(44, y - 2, 213, 20, 1075207, 0x7FFF); // Stop Song
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Box?.Deleted != false)
{

View file

@ -86,7 +86,7 @@ public partial class BrokenBedDeed : BaseAddonDeed
AddHtmlLocalized(44, 71, 213, 20, 1075387, 0x7FFF); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID == 0)
{

View file

@ -81,7 +81,7 @@ public partial class BrokenVanityDeed : BaseAddonDeed
AddHtmlLocalized(44, 71, 213, 20, 1075387, 0x7FFF); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID == 0)
{

View file

@ -80,7 +80,7 @@ public partial class HearthOfHomeFireDeed : BaseAddonDeed
AddButton(185, 35, 0x868, 0x869, 2); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed.Deleted || info.ButtonID == 0)
{

View file

@ -133,7 +133,7 @@ public partial class CurtainsDeed : BaseAddonDeed
AddHtmlLocalized(44, 71, 213, 20, 1075387, 0x7FFF); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID == 0)
{

View file

@ -81,7 +81,7 @@ public partial class HangingAxesDeed : BaseAddonDeed
AddHtmlLocalized(44, 71, 213, 20, 1075387, 0x7FFF); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Deed?.Deleted != false || info.ButtonID == 0)
{

View file

@ -81,7 +81,7 @@ public partial class HangingSwordsDeed : BaseAddonDeed
AddHtmlLocalized(44, 71, 213, 20, 1075387, 0x7FFF); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Deed?.Deleted != false || info.ButtonID == 0)
{

View file

@ -135,7 +135,7 @@ public partial class HouseLadderDeed : BaseAddonDeed
AddHtmlLocalized(44, 215, 213, 20, 1075390, 0x7FFF); // West
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID is 0 or < 1 or > 8)
{

View file

@ -83,7 +83,7 @@ public partial class StoneStatueDeed : BaseAddonDeed
AddHtmlLocalized(44, 71, 213, 20, 1075387, 0x7FFF); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID == 0)
{

View file

@ -85,7 +85,7 @@ public partial class UnmadeBedDeed : BaseAddonDeed
AddHtmlLocalized(44, 71, 213, 20, 1075387, 0x7FFF); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID == 0)
{

View file

@ -82,7 +82,7 @@ public partial class VanityDeed : BaseAddonContainerDeed
AddHtmlLocalized(44, 71, 213, 20, 1075387, 0x7FFF); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID == 0)
{

View file

@ -93,7 +93,7 @@ public partial class WoodenCoffinDeed : BaseAddonDeed
AddHtmlLocalized(44, 71, 213, 20, 1075387, 0x7FFF); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID == 0)
{

View file

@ -77,7 +77,7 @@ public partial class PottedPlantDeed : Item
AddButton(295, 50, 0x845, 0x846, 5);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false)
{

View file

@ -106,7 +106,7 @@ public partial class SnowStatueDeed : Item
AddButton(275, 50, 0x845, 0x846, 4);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false)
{

View file

@ -127,7 +127,7 @@ public partial class WreathAddon : Item, IDyable, IAddon
AddButton(20, 125, 0xFA5, 0xFA7, 0);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_addon.Deleted)
{
@ -286,7 +286,7 @@ public partial class WreathDeed : Item
AddButton(145, 35, 0x868, 0x869, 2);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed.Deleted)
{

View file

@ -164,7 +164,7 @@ public class HouseRaffleManagementGump : Gump
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public string Color(string text, int color) => $"<BASEFONT COLOR=#{color:X6}>{text}</BASEFONT>";
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
var from = sender.Mobile;
var buttonId = info.ButtonID;

View file

@ -256,7 +256,7 @@ public partial class MonsterStatuette : Item, IRewardItem
AddHtmlLocalized(190, 55, 100, 35, 1011012); // CANCEL
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
var from = sender.Mobile;

View file

@ -315,7 +315,7 @@ public partial class SoulStone : Item, ISecurable
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (info.ButtonID == 0 || !_stone.IsEmpty)
{
@ -406,7 +406,7 @@ public partial class SoulStone : Item, ISecurable
AddHtmlLocalized(45, 412, 450, 20, 1060051, 0x7FFF); // CANCEL
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (info.ButtonID == 0 || !_stone.IsEmpty)
{
@ -552,7 +552,7 @@ public partial class SoulStone : Item, ISecurable
AddHtmlLocalized(45, 412, 450, 20, 1060051, 0x7FFF); // CANCEL
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (info.ButtonID == 0 || _stone.IsEmpty)
{
@ -767,7 +767,7 @@ public partial class SoulStone : Item, ISecurable
AddHtmlLocalized(45, 412, 450, 20, 1060051, 0x7FFF); // CANCEL
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (info.ButtonID == 0 || _stone.IsEmpty)
{
@ -813,7 +813,7 @@ public partial class SoulStone : Item, ISecurable
AddHtmlLocalized(45, 412, 450, 20, 1060051, 0x7FFF); // CANCEL
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (info.ButtonID == 0)
{

View file

@ -120,7 +120,7 @@ public abstract partial class SpecialScroll : Item
}
}
public override void OnResponse(NetState state, RelayInfo info)
public override void OnResponse(NetState state, in RelayInfo info)
{
if (info.ButtonID == 1)
{

View file

@ -129,7 +129,7 @@ public partial class AnkhOfSacrificeComponent : AddonComponent
{
}
public override void OnResponse(NetState state, RelayInfo info)
public override void OnResponse(NetState state, in RelayInfo info)
{
var from = state.Mobile;

View file

@ -193,7 +193,7 @@ public partial class BannerDeed : Item, IRewardItem
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_banner?.Deleted != false)
{
@ -324,7 +324,7 @@ public partial class BannerDeed : Item, IRewardItem
AddButton(145, 35, 0x868, 0x869, (int)Buttons.South);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (m_Banner?.Deleted != false || m_House == null)
{

View file

@ -176,7 +176,7 @@ public partial class RewardBrazierDeed : Item, IRewardItem
AddButton(115, 50, 0x845, 0x846, 0x19BB);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_brazier?.Deleted != false)
{

View file

@ -339,7 +339,7 @@ public partial class CannonAddon : BaseAddon
AddHtmlLocalized(195, 109, 120, 20, 1076197, 0x7FFF); // Recharge
}
public override void OnResponse(NetState state, RelayInfo info)
public override void OnResponse(NetState state, in RelayInfo info)
{
if (_cannon?.Deleted == false && info.ButtonID == (int)Buttons.Recharge)
{

View file

@ -191,7 +191,7 @@ public partial class DecorativeShieldDeed : Item, IRewardItem
}
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_shield?.Deleted != false ||
info.ButtonID is < Start or > End ||
@ -316,7 +316,7 @@ public partial class DecorativeShieldDeed : Item, IRewardItem
AddButton(145, 35, 0x867, 0x869, (int)Buttons.South);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_shield?.Deleted != false || _house == null)
{

View file

@ -178,7 +178,7 @@ public partial class HangingSkeletonDeed : Item, IRewardItem
AddButton(390, 50, 0x845, 0x846, 0x1B7F);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID != 0x1A03 && info.ButtonID != 0x1A05 &&
info.ButtonID != 0x1A09 && info.ButtonID != 0x1B1E && info.ButtonID != 0x1B7F)
@ -303,7 +303,7 @@ public partial class HangingSkeletonDeed : Item, IRewardItem
AddButton(145, 35, 0x868, 0x869, (int)Buttons.South);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_skeleton?.Deleted != false || _house == null)
{

View file

@ -107,7 +107,7 @@ public partial class PottedCactusDeed : Item, IRewardItem
AddButton(355, 50, 0x845, 0x846, 0x1E13);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID is < 0x1E0F or > 0x1E14)
{

View file

@ -172,7 +172,7 @@ public partial class StoneAnkhDeed : BaseAddonDeed, IRewardItem
AddButton(145, 35, 0x867, 0x869, (int)Buttons.East); // East
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_deed?.Deleted != false || info.ButtonID == (int)Buttons.Cancel)
{

View file

@ -466,7 +466,7 @@ public partial class WallBannerDeed : BaseAddonDeed, IRewardItem
AddButton(70, 205, 0x8AF, 0x8AF, 0, GumpButtonType.Page, 4);
}
public override void OnResponse(NetState sender, RelayInfo info)
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (_wallBanner?.Deleted != false || info.ButtonID is <= 0 or >= 31)
{

View file

@ -217,7 +217,7 @@ public partial class WeaponEngravingTool : Item, IUsesRemaining, IRewardItem
AddTextEntry(75, 245, 350, 40, 0x0, (int)Buttons.Text, "");
}
public override void OnResponse(NetState state, RelayInfo info)
public override void OnResponse(NetState state, in RelayInfo info)
{
if (_tool?.Deleted != false || _target?.Deleted != false)
{
@ -237,7 +237,7 @@ public partial class WeaponEngravingTool : Item, IUsesRemaining, IRewardItem
return;
}
if (string.IsNullOrEmpty(relay.Text))
if (string.IsNullOrEmpty(relay))
{
_target.EngravedText = null;
state.Mobile.SendLocalizedMessage(1072362); // You remove the engraving from the object.
@ -245,7 +245,7 @@ public partial class WeaponEngravingTool : Item, IUsesRemaining, IRewardItem
else
{
_target.EngravedText =
Utility.FixHtml(relay.Text.Length > 64 ? relay.Text[..64] : relay.Text);
Utility.FixHtml(relay.Length > 64 ? relay[..64] : relay);
state.Mobile.SendLocalizedMessage(1072361); // You engraved the object.
_target.InvalidateProperties();
_tool.UsesRemaining -= 1;
@ -299,7 +299,7 @@ public partial class WeaponEngravingTool : Item, IUsesRemaining, IRewardItem
AddHtmlLocalized(40, 109, 100, 20, 1060051, 0x7FFF); // CANCEL
}
public override void OnResponse(NetState state, RelayInfo info)
public override void OnResponse(NetState state, in RelayInfo info)
{
if (_engraver?.Deleted != false || info.ButtonID != (int)Buttons.Confirm)
{