fix: Fixes addons that do not give deeds (#1224)

Projects/UOContent/Items/Addons/AddonComponent.cs

@@ -40,7 +40,7 @@ namespace Server.Items
     [SerializationGenerator(1, false)]
     public partial class AddonComponent : Item, IChoppable
     {
-        private static readonly LightEntry[] m_Entries =
+        private static LightEntry[] _entries =
         {
             new(
                 LightType.WestSmall,
@@ -196,9 +196,9 @@ namespace Server.Items
 
             var itemID = item.ItemID;
 
-            for (var i = 0; i < m_Entries.Length; ++i)
+            for (var i = 0; i < _entries.Length; ++i)
             {
-                var entry = m_Entries[i];
+                var entry = _entries[i];
                 var toMatch = entry.m_ItemIDs;
                 var contains = false;
 

Projects/UOContent/Items/Addons/ArcaneCircleAddon.cs

@@ -2,7 +2,7 @@ using ModernUO.Serialization;
 
 namespace Server.Items
 {
-    [SerializationGenerator(1)]
+    [SerializationGenerator(0)]
     public partial class ArcaneCircleAddon : BaseAddon
     {
         [Constructible]
@@ -20,26 +20,6 @@ namespace Server.Items
         }
 
         public override BaseAddonDeed Deed => new ArcaneCircleDeed();
-
-        private void Deserialize(IGenericReader reader, int version)
-        {
-            if (version == 0)
-            {
-                ValidationQueue<ArcaneCircleAddon>.Add(this);
-            }
-        }
-
-        public void Validate()
-        {
-            foreach (var c in Components)
-            {
-                if (c.ItemID == 0x3083)
-                {
-                    c.Offset = new Point3D(-1, -1, 0);
-                    c.MoveToWorld(new Point3D(X + c.Offset.X, Y + c.Offset.Y, Z + c.Offset.Z), Map);
-                }
-            }
-        }
     }
 
     [SerializationGenerator(0)]

Projects/UOContent/Items/Addons/BallotBox.cs

@@ -320,6 +320,8 @@ namespace Server.Items
         {
             AddComponent(new BallotBox(), 0, 0, 0);
         }
+
+        public override BaseAddonDeed Deed => new BallotBoxDeed();
     }
 
     [SerializationGenerator(0)]

Projects/UOContent/Items/Addons/JackOLantern.cs

@@ -39,19 +39,5 @@ namespace Server.Items
                 Hue = hue,
                 Name = "jack-o-lantern"
             };
-
-        private void Deserialize(IGenericReader reader, int version)
-        {
-            for (var i = 0; i < Components.Count; ++i)
-            {
-                var ac = Components[i];
-                ac.Name = "jack-o-lantern";
-
-                if (ac.Hue == 2118)
-                {
-                    ac.Hue = 1161;
-                }
-            }
-        }
     }
 }

Projects/UOContent/Items/Addons/PickpocketDips.cs

@@ -127,6 +127,8 @@ namespace Server.Items
         {
             AddComponent(new PickpocketDip(0x1EC3), 0, 0, 0);
         }
+
+        public override BaseAddonDeed Deed => new PickpocketDipEastDeed();
     }
 
     [SerializationGenerator(0, false)]

Projects/UOContent/Migrations/Server.Items.ArcaneCircleAddon.v0.json

@@ -1,4 +1,4 @@
 {
-  "version": 1,
+  "version": 0,
   "type": "Server.Items.ArcaneCircleAddon"
-}
+}