fix: Fixes spell mechanics and misc bugs (#1118)

- [X] Fixes NPE from account tags.
- [X] Fixes bad skill check due to missing cast to double.
- [X] Fixes water elemental duration.
- [X] Standardizes spell summon duration by expansion.
This commit is contained in:
Kamron Batman 2022-07-14 22:01:59 -07:00 • committed by GitHub
parent 2ab0a0e063
commit d6d02de296
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
24 changed files with 74 additions and 66 deletions

View file

@ -635,6 +635,11 @@ namespace Server.Accounting
/// <param name="name">Tag name to remove.</param>
public void RemoveTag(string name)
{
if (_tags == null)
{
return;
}
for (var i = _tags.Count - 1; i >= 0; --i)
{
if (i >= _tags.Count)
@ -646,7 +651,7 @@ namespace Server.Accounting
if (tag.Name == name)
{
_tags?.RemoveAt(i);
_tags.RemoveAt(i);
this.MarkDirty();
}
}