fix: Fixes spell mechanics and misc bugs (#1118)

- [X] Fixes NPE from account tags.
- [X] Fixes bad skill check due to missing cast to double.
- [X] Fixes water elemental duration.
- [X] Standardizes spell summon duration by expansion.
This commit is contained in:
Kamron Batman 2022-07-14 22:01:59 -07:00 committed by GitHub
parent 2ab0a0e063
commit d6d02de296
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
24 changed files with 74 additions and 66 deletions

View file

@ -1329,9 +1329,7 @@ namespace Server.Gumps
var loginList = acct.LoginIPs;
var contains = false;
for (var i = 0; !contains && i < loginList.Length; ++i)
for (var i = 0; i < loginList.Length; ++i)
{
if (firewallEntry.IsBlocked(loginList[i]))
{
@ -2653,7 +2651,7 @@ namespace Server.Gumps
{
index -= 2;
if (m_List != null && index >= 0 && index < m_List.Count)
if (index < m_List?.Count)
{
if (m_List[index] is not NetState ns)
{