fix: Cleans up some string allocations from trim (#1759)

This commit is contained in:
Kamron Batman 2024-05-03 22:43:11 -07:00 • committed by GitHub
parent 9d2f471e91
commit d77668d77a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 15 additions and 22 deletions

View file

@ -50,13 +50,7 @@ namespace Server.Gumps
var g = m_List[i];
string name;
if ((name = g.Name) != null && (name = name.Trim()).Length <= 0)
{
name = "(empty)";
}
string name = g.Name?.Trim().DefaultIfNullOrEmpty("(empty)");
AddLabel(radio ? 55 : 20, 35 + i % 11 * 30, 0, name);
}
}

View file

@ -51,13 +51,7 @@ namespace Server.Gumps
var m = m_List[i];
string name;
if ((name = m.Name) != null && (name = name.Trim()).Length <= 0)
{
name = "(empty)";
}
string name = m.Name?.Trim().DefaultIfNullOrEmpty("(empty)");
AddLabel(radio ? 55 : 20, 35 + i % 11 * 30, 0, name);
}
}

View file

@ -1,3 +1,4 @@
using System;
using Server.Factions;
using Server.Gumps;
using Server.Mobiles;
@ -173,7 +174,7 @@ namespace Server.Guilds
return;
}
var charter = text.Trim().FixHtml();
var charter = text.AsSpan().Trim().FixHtml();
if (charter.Length > 50)
{
@ -193,7 +194,7 @@ namespace Server.Guilds
return;
}
var site = text.Trim().FixHtml();
var site = text.AsSpan().Trim().FixHtml();
if (site.Length > 50)
{

View file

@ -1,3 +1,4 @@
using System;
using Server.Gumps;
using Server.Mobiles;
using Server.Network;
@ -265,7 +266,7 @@ namespace Server.Guilds
return;
}
var title = text.Trim().FixHtml();
var title = text.AsSpan().Trim().FixHtml();
if (title.Length > 20)
{

View file

@ -677,7 +677,7 @@ namespace Server.Guilds
}
else
{
var name = text.Trim().FixHtml();
var name = text.AsSpan().Trim().FixHtml();
if (!CheckProfanity(name))
{