Modernization Fixes & Updates to Default Values (#3)

Scripts/Items/Containers/FillableContainers.cs

@@ -199,7 +199,7 @@ namespace Server.Items
 
         if (item == null)
           continue;
-        
+
         List<Item> list = Items;
 
         for (int j = 0; j < list.Count; ++j)
@@ -1430,7 +1430,7 @@ namespace Server.Items
         new FillableEntry(1, typeof(Arrow))
       });
 
-    private static Hashtable m_AcquireTable;
+    private static Dictionary<Type, FillableContent> m_AcquireTable;
 
     private static FillableContent[] m_ContentTypes =
     {
@@ -1509,7 +1509,7 @@ namespace Server.Items
 
       if (m_AcquireTable == null)
       {
-        m_AcquireTable = new Hashtable();
+        m_AcquireTable = new Dictionary<Type, FillableContent>();
 
         for (int i = 0; i < m_ContentTypes.Length; ++i)
         {
@@ -1539,4 +1539,4 @@ namespace Server.Items
       return content;
     }
   }
-}
+}

Scripts/Items/Containers/LockableContainer.cs

@@ -38,7 +38,7 @@ namespace Server.Items
         KeyValue = key.KeyValue;
         DropItem(key);
 
-        double tinkering = from.Skills[SkillName.Tinkering].Value;
+        double tinkering = from.Skills.Tinkering.Value;
         int level = (int)(tinkering * 0.8);
 
         RequiredSkill = level - 4;

Scripts/Items/Containers/SalvageBag.cs

@@ -100,7 +100,7 @@ namespace Server.Items
             item is BaseWeapon weapon && weapon.PlayerConstructed ||
             item is BaseClothing clothing && clothing.PlayerConstructed)
         {
-          double mining = from.Skills[SkillName.Mining].Value;
+          double mining = from.Skills.Mining.Value;
           if (mining > 100.0)
             mining = 100.0;
           double amount = ((4 + mining) * craftResource.Amount - 4) * 0.0068;
@@ -114,7 +114,7 @@ namespace Server.Items
           ingot.Amount = 2;
         }
 
-        if (difficulty > from.Skills[SkillName.Mining].Value)
+        if (difficulty > from.Skills.Mining.Value)
         {
           m_Failure = true;
           ingot.Delete();

Scripts/Items/Containers/TreasureMapChest.cs

@@ -488,7 +488,7 @@ namespace Server.Items
       if (!from.Alive)
         return;
 
-      from.CloseGump(typeof(RemoveGump));
+      from.CloseGump<RemoveGump>();
       from.SendGump(new RemoveGump(from, this));
     }