From e8396d25ec1a9b1b272a20ad1dc4dcf7429173c4 Mon Sep 17 00:00:00 2001 From: Kamron Batman <3953314+kamronbatman@users.noreply.github.com> Date: Tue, 27 Dec 2022 16:56:59 -0800 Subject: [PATCH] fix: Fixes ValueStringBuilder infinite loop (#1311) --- Projects/Server/Buffers/ValueStringBuilder.cs | 1 + .../Commands/Generic/Implementors/BaseCommandImplementor.cs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Projects/Server/Buffers/ValueStringBuilder.cs b/Projects/Server/Buffers/ValueStringBuilder.cs index 79e1b687a..b5a0e8c24 100644 --- a/Projects/Server/Buffers/ValueStringBuilder.cs +++ b/Projects/Server/Buffers/ValueStringBuilder.cs @@ -187,6 +187,7 @@ public ref struct ValueStringBuilder while (!((ISpanFormattable)value).TryFormat(destination, out charsWritten, format, default)) { Grow(1); + destination = _chars[_length..]; } if ((uint)charsWritten > (uint)destination.Length) diff --git a/Projects/UOContent/Commands/Generic/Implementors/BaseCommandImplementor.cs b/Projects/UOContent/Commands/Generic/Implementors/BaseCommandImplementor.cs index 288ba0040..55f16f754 100644 --- a/Projects/UOContent/Commands/Generic/Implementors/BaseCommandImplementor.cs +++ b/Projects/UOContent/Commands/Generic/Implementors/BaseCommandImplementor.cs @@ -176,7 +176,7 @@ namespace Server.Commands.Generic } } - public string GenerateArgString(string[] args) + public static string GenerateArgString(string[] args) { if (args.Length == 0) {