Fixes dupe exception (#258)

- [X] Cleans up ActivatorUtil
- [X] Fixes dupe exception
- [X] Fixes a bug in BasePotion
- [X] Fixes a few possible memory leaks

Bumps release version
This commit is contained in:
Kamron Batman 2020-09-19 15:46:07 -07:00 • committed by GitHub
parent 4d6e584b6c
commit e9c1e4cbba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
66 changed files with 597 additions and 496 deletions

View file

@ -780,7 +780,7 @@ namespace Server
try
{
return ActivatorUtil.CreateInstance(type) as Item;
return type.CreateInstance<Item>();
}
catch
{

View file

@ -1066,7 +1066,7 @@ namespace Server
}
else
{
item = ActivatorUtil.CreateInstance(Type) as Item;
item = Type.CreateInstance<Item>();
}
return item;

View file

@ -29,7 +29,9 @@ namespace Server
public static void GiveArtifactTo(Mobile m)
{
if (!(ActivatorUtil.CreateInstance(Artifacts.RandomElement()) is Item item))
var item = Artifacts.RandomElement().CreateInstance<Item>();
if (item == null)
{
return;
}