From ee0c8c256db4887fabe654aa4a1de7394ba47f59 Mon Sep 17 00:00:00 2001
From: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
Date: Sun, 19 Jul 2026 11:05:15 -0700
Subject: [PATCH] =?UTF-8?q?feat(objects):=20DiscoverConstructibleTypes=20?=
 =?UTF-8?q?=E2=80=94=20all=20constructible=20Item/Mobile=20types?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Implement DiscoverConstructibleTypes() method with HasConstructibleCtor helper
to enumerate every non-abstract Item/Mobile subclass in AssemblyHandler.Assemblies
that has at least one [Constructible] ctor.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../Commands/Objects/ObjectDiscoveryTests.cs  | 19 +++++++++
 .../Object Creation/ObjectIntrospection.cs    | 41 +++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 Projects/UOContent.Tests/Tests/Commands/Objects/ObjectDiscoveryTests.cs

diff --git a/Projects/UOContent.Tests/Tests/Commands/Objects/ObjectDiscoveryTests.cs b/Projects/UOContent.Tests/Tests/Commands/Objects/ObjectDiscoveryTests.cs
new file mode 100644
index 000000000..d36f8bb8a
--- /dev/null
+++ b/Projects/UOContent.Tests/Tests/Commands/Objects/ObjectDiscoveryTests.cs
@@ -0,0 +1,19 @@
+using Server.Commands;
+using Server.Items;
+using Xunit;
+
+namespace UOContent.Tests.Commands.Objects;
+
+[Collection("Sequential UOContent Tests")]
+public class ObjectDiscoveryTests
+{
+    [Fact]
+    public void Discover_includes_concrete_constructibles_and_excludes_abstract()
+    {
+        var types = ObjectIntrospection.DiscoverConstructibleTypes();
+
+        Assert.Contains(typeof(Katana), types);
+        Assert.Contains(typeof(Runebook), types);
+        Assert.DoesNotContain(typeof(BaseWeapon), types); // abstract
+    }
+}
diff --git a/Projects/UOContent/Commands/Object Creation/ObjectIntrospection.cs b/Projects/UOContent/Commands/Object Creation/ObjectIntrospection.cs
index f4d076f97..f0a11b31c 100644
--- a/Projects/UOContent/Commands/Object Creation/ObjectIntrospection.cs	
+++ b/Projects/UOContent/Commands/Object Creation/ObjectIntrospection.cs	
@@ -184,4 +184,45 @@ public static class ObjectIntrospection
 
         return lines;
     }
+
+    public static List<Type> DiscoverConstructibleTypes()
+    {
+        var results = new List<Type>();
+
+        foreach (var asm in AssemblyHandler.Assemblies)
+        {
+            foreach (var type in AssemblyHandler.GetTypeCache(asm).Types)
+            {
+                if (type.IsAbstract)
+                {
+                    continue;
+                }
+
+                if (!typeof(Item).IsAssignableFrom(type) && !typeof(Mobile).IsAssignableFrom(type))
+                {
+                    continue;
+                }
+
+                if (HasConstructibleCtor(type))
+                {
+                    results.Add(type);
+                }
+            }
+        }
+
+        return results;
+    }
+
+    private static bool HasConstructibleCtor(Type type)
+    {
+        foreach (var ctor in type.GetConstructors())
+        {
+            if (Attributes.IsConstructible(ctor, AccessLevel.Developer))
+            {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }