warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Moves ContextMenu out of core, streamlines code, fixes bugs (#1873)

Browse source 
## Summary
- Removes allocation of a `List<ContextMenuEntry>` every time a context menu is created.
- Moves packet/context menu creation logic out of the core
- Fixes tame entry

## BREAKING CHANGE
> [!Important]
> **Developer Note**
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list)
> ```
> and similar functions changed to
> ```cs
> public virtual void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)
> ```
This commit is contained in:
Kamron Batman 2024-07-20 21:33:23 -07:00 • committed by GitHub
parent bb24b330e1
commit f58117a877
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
88 changed files with 1206 additions and 1483 deletions
Download patch file Download diff file Expand all files Collapse all files

40
Projects/UOContent/Context Menus/AddToParty.cs
View file

@ -4,47 +4,47 @@ namespace Server.ContextMenus
{
public class AddToPartyEntry : ContextMenuEntry
{
private readonly Mobile m_From;
private readonly Mobile m_Target;
public AddToPartyEntry(Mobile from, Mobile target) : base(0197, 12)
public AddToPartyEntry() : base(0197, 12)
{
m_From = from;
m_Target = target;
}
public override void OnClick()
public override void OnClick(Mobile from, IEntity target)
{
var p = Party.Get(m_From);
var mp = Party.Get(m_Target);
if (m_From == m_Target)
if (target is not Mobile targetMobile)
{
m_From.SendLocalizedMessage(1005439); // You cannot add yourself to a party.
return;
}
else if (p != null && p.Leader != m_From)
var p = Party.Get(from);
var mp = Party.Get(targetMobile);
if (from == targetMobile)
{
m_From.SendLocalizedMessage(1005453); // You may only add members to the party if you are the leader.
from.SendLocalizedMessage(1005439); // You cannot add yourself to a party.
}
else if (p != null && p.Leader != from)
{
from.SendLocalizedMessage(1005453); // You may only add members to the party if you are the leader.
}
else if (p != null && p.Members.Count + p.Candidates.Count >= Party.Capacity)
{
m_From.SendLocalizedMessage(1008095); // You may only have 10 in your party (this includes candidates).
from.SendLocalizedMessage(1008095); // You may only have 10 in your party (this includes candidates).
}
else if (!m_Target.Player)
else if (!targetMobile.Player)
{
m_From.SendLocalizedMessage(1005444); // The creature ignores your offer.
from.SendLocalizedMessage(1005444); // The creature ignores your offer.
}
else if (mp != null && mp == p)
{
m_From.SendLocalizedMessage(1005440); // This person is already in your party!
from.SendLocalizedMessage(1005440); // This person is already in your party!
}
else if (mp != null)
{
m_From.SendLocalizedMessage(1005441); // This person is already in a party!
from.SendLocalizedMessage(1005441); // This person is already in a party!
}
else
{
Party.Invite(m_From, m_Target);
Party.Invite(from, targetMobile);
}
}
}